Skip to content

Conversation

@DelloStritto
Copy link
Contributor

No description provided.

@vkucera
Copy link
Collaborator

vkucera commented Feb 18, 2021

As discussed, please adjust the decay strings and use named PDG values where possible.

@vkucera
Copy link
Collaborator

vkucera commented Feb 20, 2021

Also please fix /// \file HFD0CandidateSelector.cxx.

@DelloStritto DelloStritto force-pushed the dev branch 3 times, most recently from 3ab621e to 8991fb3 Compare February 25, 2021 13:01
@DelloStritto
Copy link
Contributor Author

As discussed, please adjust the decay strings and use named PDG values where possible.

Done!

@vkucera
Copy link
Collaborator

vkucera commented Feb 26, 2021

Can you please also adjust the decay strings to LcToPKPi in the code, file names, function names, and columns and tables in hf_selcandidate_lc?

@DelloStritto
Copy link
Contributor Author

Can you please also adjust the decay strings to LcToPKPi in the code, file names, function names, and columns and tables in hf_selcandidate_lc?

I would prefer to do it in a separate pull request. These change will include a lot of files that are already involved in other pull request so I will generate a lot of conflicts.
If it's fine with you I would start merging the PID pull request and then I can open a "clean up" pull request with the name changes.

@vkucera
Copy link
Collaborator

vkucera commented Feb 27, 2021

Can you please also adjust the decay strings to LcToPKPi in the code, file names, function names, and columns and tables in hf_selcandidate_lc?

I would prefer to do it in a separate pull request. These change will include a lot of files that are already involved in other pull request so I will generate a lot of conflicts.
If it's fine with you I would start merging the PID pull request and then I can open a "clean up" pull request with the name changes.

OK, as you prefer. Let's keep it for the big renaming commit then.

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginnocen Looks good to me.

@ginnocen
Copy link
Collaborator

ginnocen commented Mar 1, 2021

@vkucera please resolve the conversations if closed.

@ginnocen ginnocen marked this pull request as ready for review March 1, 2021 22:59
@ginnocen ginnocen self-requested a review as a code owner March 1, 2021 22:59
@ginnocen ginnocen merged commit 6e3ec44 into AliceO2Group:dev Mar 2, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Co-authored-by: Luigi <ldellost@aliceml.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants