PWGHF: implement event selection in track-index skim creator#6016
Merged
iarsene merged 16 commits intoAliceO2Group:devfrom May 26, 2021
Merged
PWGHF: implement event selection in track-index skim creator#6016iarsene merged 16 commits intoAliceO2Group:devfrom
iarsene merged 16 commits intoAliceO2Group:devfrom
Conversation
aalkin
reviewed
Apr 27, 2021
aalkin
reviewed
Apr 27, 2021
vkucera
reviewed
May 4, 2021
Analysis/DataModel/include/AnalysisDataModel/HFSecondaryVertex.h
Outdated
Show resolved
Hide resolved
vkucera
reviewed
May 4, 2021
vkucera
reviewed
May 4, 2021
ginnocen
reviewed
May 11, 2021
Collaborator
|
hi @fgrosa please have a look, implement the comments if you think are useful and then flip it to ready for review. Thanks! |
ginnocen
previously approved these changes
May 12, 2021
Collaborator
Collaborator
Collaborator
|
Ok @vkucera I will wait. |
Collaborator
|
@fgrosa Please rebase and resolve conflicts. |
Collaborator
Author
Hi @vkucera I have fixed them, and I also added the event selection in the workflow for V0s added by @chiarazampolli (please have a look if it is fine with you) |
Collaborator
Collaborator
Author
Hi @ginnocen indeed it looks to me that the errors are unrelated to the PR (they also change in time, sometimes is only build/O2/o2, sometimes both, sometimes none). Thanks! |
ginnocen
approved these changes
May 25, 2021
Collaborator
vkucera
approved these changes
May 25, 2021
Collaborator
|
The fullCI and o2 fails are not related. |
ginnocen
pushed a commit
to ginnocen/AliceO2
that referenced
this pull request
May 26, 2021
…liceO2Group#6016)" This reverts commit 65c3f9b.
vkucera
added a commit
to vkucera/AliceO2
that referenced
this pull request
May 26, 2021
…liceO2Group#6016)" This reverts commit 65c3f9b.
vkucera
added a commit
to vkucera/AliceO2
that referenced
this pull request
May 26, 2021
…liceO2Group#6016)" This reverts commit 65c3f9b.
aalkin
added a commit
to aalkin/AliceO2
that referenced
this pull request
Jun 4, 2021
…liceO2Group#6016)" This reverts commit 65c3f9b.
cortesep
pushed a commit
to cortesep/AliceO2
that referenced
this pull request
Jun 11, 2021
…Group#6016) * Add workflow for event tagging * Remove placeholder for event selection * Add missing header * Add histo to monitor selected/rejected events * Fix format * Fix fill of event histo and change struct name * Add missing if * Change struct names to avoit TaskName argument * Use camelCase * Use camelCase * Update name of structs * Remove output histogram * Update workflows with new struct names * Revert removal of histogram * Fix conflicts * Fix format
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
…Group#6016) * Add workflow for event tagging * Remove placeholder for event selection * Add missing header * Add histo to monitor selected/rejected events * Fix format * Fix fill of event histo and change struct name * Add missing if * Change struct names to avoit TaskName argument * Use camelCase * Use camelCase * Update name of structs * Remove output histogram * Update workflows with new struct names * Revert removal of histogram * Fix conflicts * Fix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow that tags events and store information in a table with a single bitmap used to filter the collisions in the workflow for building the candidates