Merged
Conversation
Collaborator
wiechula
commented
Nov 16, 2017
wiechula
commented
- Several small fixes in the simulation code
- Temporary possibility for realistic event times
- Small code modernisation
Collaborator
|
Error while checking build/o2/macos for 61ac3f7c43f664f223065b5f42dafddf16c364e1: Full log here. |
Collaborator
Author
|
Does anyone have an idea what to do with this error message? |
sawenzel
reviewed
Nov 17, 2017
Collaborator
There was a problem hiding this comment.
should this be put into the production version??
Collaborator
Author
There was a problem hiding this comment.
Thanks for spotting this. I'll comment it out. We should discuss a more proper solution for this, e.g. an array over all sectors indicating the active state which can be set in the macro...
sawenzel
requested changes
Nov 17, 2017
Collaborator
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
see comment; need clarification
The bunch train structure stuff is temporary since it will only work for the TPC digitisation for the moment
Conflicts: Detectors/TPC/simulation/src/ElectronTransport.cxx
wiechula
force-pushed
the
fix-simulation
branch
from
61ac3f7 to
0cf52d9
Compare
Collaborator
matthiasrichter
added a commit
to matthiasrichter/AliceO2
that referenced
this pull request
Nov 22, 2017
FairMQDevices option '--rate' was added in FairRoot PR AliceO2Group#675. The option controls the rate of ConditionalRun for data producers. The options defined in a ProcessorSpec can now be grouped together on the command line, an option is created from the spec name, e.g. --my_spec_name "--myoption1 arg myoption2 arg --rate 1" will forward the options only to devices of spec my_spec_name.
ktf
pushed a commit
that referenced
this pull request
Nov 23, 2017
FairMQDevices option '--rate' was added in FairRoot PR #675. The option controls the rate of ConditionalRun for data producers. The options defined in a ProcessorSpec can now be grouped together on the command line, an option is created from the spec name, e.g. --my_spec_name "--myoption1 arg myoption2 arg --rate 1" will forward the options only to devices of spec my_spec_name.
arvindkhuntia
pushed a commit
to arvindkhuntia/AliceO2
that referenced
this pull request
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.