TPC: generalize cluster QC, speed up Kr cluster finder, unrelated fixes and cleanup#6798
Merged
Conversation
Collaborator
wiechula
commented
Aug 2, 2021
wiechula
commented
- move KrCluster to DataFormatsTPC
- modify cluster QC to accept ClusterNative and KrCluster as input
wiechula
added a commit
to wiechula/QualityControl
that referenced
this pull request
Aug 2, 2021
wiechula
added a commit
to wiechula/QualityControl
that referenced
this pull request
Aug 2, 2021
wiechula
force-pushed
the
RawReaderCRU
branch
4 times, most recently
from
a3ee96a to
a7cf21e
Compare
* move Krcluster to DataFormatsTPC * modify cluster QC to accept ClusterNative and KrCluster as input
* Speed improvement ~30% * Don't loop over pad rows which don't have any charge above Qmax threshold * Join check for skipping time bins with the one for skipping rows
wiechula
changed the title
Collaborator
Author
|
@davidrohr, can this be merged? I think the only failing test in macos is unrelated. |
shahor02
approved these changes
Aug 6, 2021
wiechula
added a commit
to wiechula/QualityControl
that referenced
this pull request
Aug 12, 2021
wiechula
added a commit
to wiechula/QualityControl
that referenced
this pull request
Aug 13, 2021
Barthelemy
pushed a commit
to AliceO2Group/QualityControl
that referenced
this pull request
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.