TPC: Add simple raw data filter for krypton clusters#7672
Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom Nov 20, 2021
Merged
TPC: Add simple raw data filter for krypton clusters#7672shahor02 merged 2 commits intoAliceO2Group:devfrom
shahor02 merged 2 commits intoAliceO2Group:devfrom
Conversation
Collaborator
Author
|
@davidrohr , @shahor02 , the error looks unrelated. Can this be merged? |
shahor02
reviewed
Nov 20, 2021
Comment on lines
+50
to
+67
| enum class BranchType { | ||
| Krypton, | ||
| Digits, | ||
| }; | ||
|
|
||
| const std::unordered_map<std::string, BranchType> BranchTypeMap{ | ||
| {"krypton", BranchType::Krypton}, | ||
| {"digits", BranchType::Digits}, | ||
| }; | ||
|
|
||
| const std::unordered_map<BranchType, std::string> BranchName{ | ||
| {BranchType::Krypton, "TPCBoxCluster"}, | ||
| {BranchType::Digits, "TPCDigit"}, | ||
| }; | ||
|
|
||
| const std::unordered_map<BranchType, std::string> TreeName{ | ||
| {BranchType::Krypton, "Clusters"}, | ||
| {BranchType::Digits, "o2sim"}, |
Collaborator
There was a problem hiding this comment.
@wiechula there are extra , at the end of each block. The compiler does not complain but I think it is better to remove them.
Collaborator
Author
There was a problem hiding this comment.
@shahor02 as far as I know it is allowed since C99. I would like to keep it, sine it looks more symmetric and makes adding new elements a bit easier.
I think it is also used in other places in o2.
Collaborator
There was a problem hiding this comment.
ok, thought looks a bit awkward...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.