DPL: Extending ExternalFairMQDeviceProxy benchmark#7729
DPL: Extending ExternalFairMQDeviceProxy benchmark#7729matthiasrichter merged 1 commit intoAliceO2Group:devfrom
Conversation
|
This looks good. Could you please merge the two automatically opened PRs you have for it and then merge this one? |
- handle exception from shm allocation Depending on the configuration, there might not be enough shared memory, handling this exception gracefully. - more proxy bypassing options Option '--bypass-proxies' none, all(a), output(o) We can now bypass both proxies to get the metrics for the pure producer to checker traffic, or bypass output proxy only to benchmark with one proxy in between. It is not possible to have only the output proxy.
matthiasrichter
force-pushed
the
dev-benchmark-proxy
branch
from
d20c074 to
9edc7f6
Compare
|
nice tool with the automatic PRs, but naturally doesn't work with two conflicting changes, in this case I had to do it manually. And can "squash and commit" be selected by default? |
|
If you merged one, then the second one would have been updated at some point. I will check if it's possible to make "squash and merge" default. |
|
Apparently it's not possible... |
|
@ktf I would add the reference to the text of the PR not only the title, and the project needs to be in the reference I think. So that GitHub is adding cross links to the original PR. This will make the suggestions more visible. I have noticed the feature only now when you mentioned it. Something like "This is a follow-up to AliceO2Group/AliceO2#PR ." I'm not exactly sure about the syntax I reopened, think you have closed accidentally. |
|
I think I already updated the script in a way which is close to your suggestion. See: you might have to rebase in order to see the new message... |
|
very good! |
2 participants
Depending on the configuration, there might not be enough shared memory,
handling this exception gracefully.
Option '--bypass-proxies' none, all(a), output(o)
We can now bypass both proxies to get the metrics for the pure producer
to checker traffic, or bypass output proxy only to benchmark with one
proxy in between. It is not possible to have only the output proxy.