add TOF diagnostic from ccdb in digitisation (empty crates, TRM errors)#7737
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Nov 28, 2021
Merged
add TOF diagnostic from ccdb in digitisation (empty crates, TRM errors)#7737shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02 merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
Author
|
I forgot to say that for the moment to enable ccdb in MC I followed the same philosophy of reconstruction by adding a flag |
noferini
force-pushed
the
dev
branch
2 times, most recently
from
52470e2 to
824a69a
Compare
Collaborator
Author
|
all checks have passed |
shahor02
reviewed
Nov 26, 2021
Comment on lines
52
to
53
Collaborator
There was a problem hiding this comment.
Aren't these const methods?
Collaborator
Author
There was a problem hiding this comment.
Yes, they are. Moved to const (including also other non static getters).
shahor02
approved these changes
Nov 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in simulation (@chiarazampolli ) to read from ccdb
tested with pythia 1000 events@50 kHz (1 TF) using diagnostic of a run with only 1 crate -> digit QC as expected (matching data QC)