CTF dictionaries are ready to be fetched from CCDB#7764
Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom Dec 1, 2021
Merged
CTF dictionaries are ready to be fetched from CCDB#7764shahor02 merged 2 commits intoAliceO2Group:devfrom
shahor02 merged 2 commits intoAliceO2Group:devfrom
Conversation
shahor02
requested review from
a team,
AllaMaevskaya,
aphecetche,
bazinski,
bovulpes,
davidrohr,
iouribelikov,
jolopezl,
jotwinow,
kharlov,
martenole,
mfasDa,
mslupeck,
noferini,
peressounko,
rpezzi,
sawenzel,
tdietel and
wiechula
as code owners
Collaborator
MichaelLettrich
left a comment
MichaelLettrich
left a comment
There was a problem hiding this comment.
Changes look fine for me. I will rebase once you merged your changes and add my adaptations.
However I would strongly recommend to factor out the getFreq and getProbBits lambdas as functions from the individual CTF Coders, as this level of copy-paste code duplication is widely considered a code smell. If you share my opinion but lack the time to do it I can take care of it in a separate PR.
shahor02
force-pushed
the
pr_ctfdictCCDB
branch
2 times, most recently
from
d6c99d2 to
5852f5b
Compare
Collaborator
Author
|
@MichaelLettrich the |
MichaelLettrich
previously approved these changes
Nov 30, 2021
Collaborator
MichaelLettrich
left a comment
MichaelLettrich
left a comment
There was a problem hiding this comment.
Thanks for taking my comments into consideration. I think this makes the CTF Coders more maintainable.
shahor02
force-pushed
the
pr_ctfdictCCDB
branch
from
5852f5b to
90afcc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o2-ctf-writer-workflow.The dictionaries used for the commissioning are uploaded to http://alice-ccdb.cern.ch//Calib/CTFDictionary with validity from 16/07/21 to 12/05/22.
@MichaelLettrich note there were some changes in the createCoders methods.