Skip to content

DPL: cleanup struct to tuple#7768

Merged
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:cleanup-struct-to-tuple
Nov 30, 2021
Merged

DPL: cleanup struct to tuple#7768
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:cleanup-struct-to-tuple

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Nov 30, 2021

No description provided.

@ktf ktf requested a review from a team as a code owner November 30, 2021 12:21
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Nov 30, 2021

@jgrosseo @aalkin as discussed. Having support for 99 elements rather than 40 does not seem to have any noticeable slowdown.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Nov 30, 2021

Of course this does not mean that actually parsing 99 is not slower than parsing 40. Merely that if the concern is allowing for more configurables, we can do that without a global impact.

@ktf ktf force-pushed the cleanup-struct-to-tuple branch from 0d58ff5 to ddc1e00 Compare November 30, 2021 12:43
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Nov 30, 2021

Tested also on hyperloop, works.

@ktf ktf merged commit afdff75 into AliceO2Group:dev Nov 30, 2021
@ktf ktf deleted the cleanup-struct-to-tuple branch November 30, 2021 23:28
@jgrosseo
Copy link
Copy Markdown
Collaborator

jgrosseo commented Dec 2, 2021

@ktf Thanks! Have you tried how long it takes to compile something with 99 elements?

@jgrosseo
Copy link
Copy Markdown
Collaborator

jgrosseo commented Dec 2, 2021

Any thoughts about making this also consuming structs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants