TRD remove straggling error output and add option for trigger fix#7769
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Dec 6, 2021
Merged
TRD remove straggling error output and add option for trigger fix#7769davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
bazinski
commented
Nov 30, 2021
bazinski
commented
- option --fixforoldtrigger ignore the 2 step trigger for physics/calibration nodigit/digit data.
- remove a straggling text output for non sequential ROB, printing digit mcm header.
bazinski
requested review from
jolopezl,
martenole and
tdietel
as code owners
martenole
previously approved these changes
Nov 30, 2021
bazinski
force-pushed
the
fixtriggerforolddata
branch
from
19c51f7 to
a825159
Compare
Collaborator
|
can someone approve, then I would merge? |
Collaborator
Author
|
@tdietel @martenole could one of you approve this so i can get this off my list ;-) thanks |
martenole
reviewed
Dec 6, 2021
| *****************/ | ||
| // Check if we have a calibration trigger ergo we do actually have digits data. check if we are now at the end of the data due to bugs, i.e. if trackletparsing read padding words. | ||
| if (linkstart != linkend && mCurrentHalfCRUHeader.EventType == o2::trd::constants::ETYPECALIBRATIONTRIGGER) { // calibration trigger | ||
| if (linkstart != linkend && (mCurrentHalfCRUHeader.EventType == o2::trd::constants::ETYPECALIBRATIONTRIGGER || mOptions[TRDIgnore2StageTrigger])) { // calibration trigger |
Contributor
There was a problem hiding this comment.
So without the 2-stage trigger we always had digits in the raw data? Did you test it with both old and new raw data format?
Collaborator
Author
There was a problem hiding this comment.
Yes, but only hcheader and trailers, but it gets caught by the linkstart != linkend if there are no digits.
martenole
approved these changes
Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.