[EMCAL-729] Add compression of trigger bits#7774
Conversation
There was a problem hiding this comment.
Reference for some reason seems to not work. The trigger bits stay unmodified. Will change it in the same way as done for the cells.
There was a problem hiding this comment.
you should use auto& currenttrigger = trigVec.emplace_back(ir, firstEntry, entries[itrig])
|
@shahor02 OK, in fact besides missing adaption of the reference they were showed indeed a bug in the new decoding of compressed trigger bits. One question: Why do you prefer BOOST_CHECK with respect to BOOST_CHECK_EQUAL for the check for equal? If nothing speaks against I will change to BOOST_CHECK_EQUAL as this not only tells me that the test failed but why it failed. |
Reduction from 32 bit to 16 bit filtering the most relevant triggers for EMCAL. For the moment 2 triggers are propagated - Physics trigger - Calib trigger In case other triggers will be included in the compressed output, they need to be appended. In addition the unit test is adapted (proper reference, check for compressed and uncompressed bits)
|
In addition: Based on the discussion in the EMCAL meeting we drop the timeframe trigger from encoding. |
you can change it if you prefer. |
could you clarify what do you mean? If this is about the TF trigger bit of the RDH, you anyway don't have it, right? |
Exactly, and that's why we drop it from being encoded (with respect to the initial version) |
|
@shahor02 should be ready for merge now? |
2 participants
Reduction from 32 bit to 16 bit filtering the most
relevant triggers for EMCAL. For the moment
3 triggers are propagated
In case other triggers will be included in the
compressed output, they need to be appended.