Do not cleanup cached CCDB objects of some special types#7843
Merged
jgrosseo merged 1 commit intoAliceO2Group:devfrom Dec 9, 2021
Merged
Do not cleanup cached CCDB objects of some special types#7843jgrosseo merged 1 commit intoAliceO2Group:devfrom
jgrosseo merged 1 commit intoAliceO2Group:devfrom
Conversation
The BasicCCDBManager cache is based on shared_ptr, which assumes that the object is never deleted via its raw pointer. We cannot control this for some global ROOT pointers, e.g. gGeoManager, which is deleted on exit internally by ROOT (thus creating a race condition with destruction of the same pointer via shared_ptr. Such objects will be cached to raw pointers in the BasicCCDBManager but will be never deleted by it.
shahor02
requested review from
a team,
Barthelemy,
costing and
sawenzel
as code owners
shahor02
changed the title
Collaborator
Author
|
@victor-gonzalez @jgrosseo Once this is merged, you can probably revert the AliceO2Group/O2Physics#402. |
jgrosseo
approved these changes
Dec 8, 2021
ezradlesser
pushed a commit
to ezradlesser/AliceO2
that referenced
this pull request
Dec 15, 2021
…p#7843) The BasicCCDBManager cache is based on shared_ptr, which assumes that the object is never deleted via its raw pointer. We cannot control this for some global ROOT pointers, e.g. gGeoManager, which is deleted on exit internally by ROOT (thus creating a race condition with destruction of the same pointer via shared_ptr. Such objects will be cached to raw pointers in the BasicCCDBManager but will be never deleted by it. Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BasicCCDBManager cache is based on shared_ptr, which assumes that the object is never
deleted via its raw pointer. We cannot control this for some global ROOT pointers, e.g.
gGeoManager, which is deleted on exit internally by ROOT (thus creating a race condition with
destruction of the same pointer via shared_ptr.
Such objects will be cached to raw pointers in the BasicCCDBManager but will be never deleted by it.