readout-proxy: correctly populate TimingInfo#8606
Merged
davidrohr merged 3 commits intoAliceO2Group:devfrom Apr 22, 2022
Merged
readout-proxy: correctly populate TimingInfo#8606davidrohr merged 3 commits intoAliceO2Group:devfrom
davidrohr merged 3 commits intoAliceO2Group:devfrom
Conversation
Collaborator
|
thx, will try to test tomorrow! |
Member
Author
|
This was all green and the errors are actually unrelated (bumped glibc on CS8). Is it ok to merge it? |
This is required to have a proper firstTFOrbit message, since the PreProcessingCallback happens too early in the case of the readout proxy.
7812338 to
26d92d8
Compare
Member
Author
|
@davidrohr @shahor02 Ok, this works. Checked on my box. There are two issues:
This means that for now we need two messages per timeframe and only the "done" one will get the correct firstTFOrbit. |
Member
Author
|
E.g.: |
Member
Author
|
To properly fix this we would need to move the readout-proxy to use Lifetime::OutOfBand, which then injects data at the right moment like any other input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.