Skip to content

[deps] Migration to new eslint v9 to flat configuration#1676

Merged
graduta merged 8 commits into
mainfrom
deps/graduta/migrate-to-eslint-major-version
Jun 26, 2025
Merged

[deps] Migration to new eslint v9 to flat configuration#1676
graduta merged 8 commits into
mainfrom
deps/graduta/migrate-to-eslint-major-version

Conversation

@graduta

@graduta graduta commented Jul 24, 2024

Copy link
Copy Markdown
Member

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for users:

  • NA

Notable changes for developers:

  • new eslint flat configuration added
  • existing configuration updated to use plugins such as jsdoc/stylistic, etc.

Changes made to the database:

@graduta graduta added the dependencies Pull requests that update a dependency file label Jul 24, 2024
@graduta graduta self-assigned this Jul 24, 2024
@graduta graduta requested a review from martinboulais as a code owner July 24, 2024 14:15
@codecov

codecov Bot commented Jul 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 17.24138% with 24 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (64fd0b9) to head (e056e5c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/common/panel/LabelPanelHeaderComponent.js 0.00% 3 Missing ⚠️
lib/public/utilities/export.js 0.00% 3 Missing ⚠️
...b/public/components/common/panel/PanelComponent.js 0.00% 2 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/Details/RunDetailsModel.js 0.00% 2 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 2 Missing ⚠️
...ib/public/views/Tags/Overview/TagsOverviewModel.js 0.00% 2 Missing ⚠️
lib/server/kafka/AliEcsSynchronizer.js 0.00% 2 Missing ⚠️
...s/v0/20230213082905-run-quality-unknown-to-null.js 0.00% 1 Missing ⚠️
...ublic/components/common/popover/overflowBalloon.js 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
+ Coverage   45.58%   45.75%   +0.16%     
==========================================
  Files        1007     1007              
  Lines       16647    16653       +6     
  Branches     2983     2983              
==========================================
+ Hits         7588     7619      +31     
+ Misses       9059     9034      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/database/migrations/20240424092020-add-qc-flag-effective-periods-table.js Outdated
Comment thread lib/public/components/Filters/common/filters/TimeRangeInputModel.js Outdated
Comment thread lib/public/components/common/form/inputs/DateTimeInputComponent.js
Comment thread lib/public/components/common/selection/dropdown/selectionDropdown.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagTypeService.js Outdated
@graduta graduta requested review from Copilot June 26, 2025 10:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project to ESLint v9 with a flat configuration and updates inline ESLint disable comments across the codebase to reflect new rule names.

  • Add ESLint v9 and required plugins to package.json, adjust lint scripts
  • Remove or replace obsolete // eslint-disable-next-line comments (e.g. require-jsdocjsdoc/require-param, max-len@stylistic/js/max-len)
  • Minor signature and docblock adjustments in utilities and use case modules

Reviewed Changes

Copilot reviewed 215 out of 216 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bump to ESLint v9, add @eslint/js, @stylistic/eslint-plugin-js, eslint-plugin-jsdoc, update lint script
scripts/update-dockerfile.js Remove unnecessary no-console disable comment
lib/usecases/run/StartRunUseCase.js Simplify catch clause by omitting unused exception binding
lib/server/utilities/dtoValidator.js Refactor dtoValidator signature and inline documentation
test/public/qcFlags/*.test.js Replace require-jsdoc disables with jsdoc/require-param
lib/server/controllers/**/*.js Update valid-jsdoc disables to jsdoc/require-param in route handlers
test/mocks/*.js Replace max-len disables with @stylistic/js/max-len
…and many other files Various inline ESLint disable comment updates for new flat config rules

@graduta graduta merged commit 4d878a6 into main Jun 26, 2025
23 of 24 checks passed
@graduta graduta deleted the deps/graduta/migrate-to-eslint-major-version branch June 26, 2025 10:41
@graduta graduta removed the request for review from Copilot March 23, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Development

Successfully merging this pull request may close these issues.

3 participants