[deps] Migration to new eslint v9 to flat configuration#1676
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 45.58% 45.75% +0.16%
==========================================
Files 1007 1007
Lines 16647 16653 +6
Branches 2983 2983
==========================================
+ Hits 7588 7619 +31
+ Misses 9059 9034 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martinboulais
suggested changes
Jul 25, 2024
…graduta/migrate-to-eslint-major-version
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project to ESLint v9 with a flat configuration and updates inline ESLint disable comments across the codebase to reflect new rule names.
- Add ESLint v9 and required plugins to
package.json, adjust lint scripts - Remove or replace obsolete
// eslint-disable-next-linecomments (e.g.require-jsdoc→jsdoc/require-param,max-len→@stylistic/js/max-len) - Minor signature and docblock adjustments in utilities and use case modules
Reviewed Changes
Copilot reviewed 215 out of 216 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bump to ESLint v9, add @eslint/js, @stylistic/eslint-plugin-js, eslint-plugin-jsdoc, update lint script |
| scripts/update-dockerfile.js | Remove unnecessary no-console disable comment |
| lib/usecases/run/StartRunUseCase.js | Simplify catch clause by omitting unused exception binding |
| lib/server/utilities/dtoValidator.js | Refactor dtoValidator signature and inline documentation |
| test/public/qcFlags/*.test.js | Replace require-jsdoc disables with jsdoc/require-param |
| lib/server/controllers/**/*.js | Update valid-jsdoc disables to jsdoc/require-param in route handlers |
| test/mocks/*.js | Replace max-len disables with @stylistic/js/max-len |
| …and many other files | Various inline ESLint disable comment updates for new flat config rules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: