Skip to content

Conversation

@graduta
Copy link
Member

@graduta graduta commented Feb 6, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Updates min supported NodeJS to 22 to cover next year of Beam Operations
  • disables usage of GPU on puppetter as it hangs on docker-alpine (known issue on their repository)
  • Updates alpine version as otherwise node 22 was not available
  • Updates dependencies for puppeteer as needed due to alpine update
  • moves to using headles: true instead of headless: 'new' with the new puppeteer version

Changes made to the database:

@graduta graduta added the CI label Feb 6, 2025
@graduta graduta self-assigned this Feb 6, 2025
@graduta graduta changed the title [CI] Bump NodeJS to v22 for GH Actions [OGUI-1610] Bump NodeJS to v22 for GH Actions Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.08%. Comparing base (2686627) to head (6efbac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   38.96%   44.08%   +5.11%     
==========================================
  Files         892      892              
  Lines       15961    15961              
  Branches     3013     3013              
==========================================
+ Hits         6219     7036     +817     
+ Misses       9742     8925     -817     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais
Copy link
Contributor

We might as well bump docker ?

@graduta graduta merged commit b875f44 into main Feb 6, 2025
23 checks passed
@graduta graduta deleted the feautre/graduta/OGUI-1610-migrate-to-node-22 branch February 6, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants