[O2B-1443] Add filter on CTF, TF and Other File counts for runs-overview page#1900
[O2B-1443] Add filter on CTF, TF and Other File counts for runs-overview page#1900
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
+ Coverage 44.62% 44.77% +0.15%
==========================================
Files 1018 1018
Lines 17124 17123 -1
Branches 3089 3087 -2
==========================================
+ Hits 7641 7667 +26
+ Misses 9483 9456 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds filtering capabilities on CTF, TF, and Other file counts for the runs overview page.
- Introduces new filter parameters in the DTO and use case
- Updates backend logic to apply the new filters
- Adds frontend models, active columns, and tests for CTF/TF filters
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/lib/usecases/run/GetAllRunsUseCase.test.js | Added tests for CTF and TF file count filters |
| lib/usecases/run/GetAllRunsUseCase.js | Applied filtering logic for ctfFileCount, tfFileCount, otherFileCount |
| lib/public/views/Runs/Overview/RunsOverviewModel.js | Registered numerical filters for the new file count fields |
| lib/public/views/Runs/ActiveColumns/runsActiveColumns.js | Enabled filter widgets and display classes for the new columns |
| lib/domain/dtos/filters/RunFilterDto.js | Extended the RunFilterDto schema with ctfFileCount, tfFileCount, otherFileCount |
Comments suppressed due to low confidence (1)
There was a problem hiding this comment.
Pull Request Overview
Adds filtering capabilities for CTF, TF, and Other file counts on the runs-overview page.
- Introduces new
ctfFileCount,tfFileCount, andotherFileCountfilter parameters in the backend use case and DTO - Adds corresponding filter models and active columns in the frontend UI
- Extends unit tests to cover filtering logic for CTF and TF file counts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/lib/usecases/run/GetAllRunsUseCase.test.js | Added tests for CTF and TF file count filters |
| lib/usecases/run/GetAllRunsUseCase.js | Refactored file‐count filters into a loop; added new filter fields |
| lib/public/views/Runs/Overview/RunsOverviewModel.js | Registered new numerical filters for CTF, TF, and Other file counts |
| lib/public/views/Runs/ActiveColumns/runsActiveColumns.js | Added columns and filter hooks for the new file count fields |
| lib/domain/dtos/filters/RunFilterDto.js | Extended the RunFilterDto schema to include CTF, TF, and Other counts |
Comments suppressed due to low confidence (1)
test/lib/usecases/run/GetAllRunsUseCase.test.js:614
- Tests cover CTF and TF filters but there’s no test for
otherFileCount. Add a similar test case forotherFileCountto ensure the new filter is properly exercised.
it('should successfully filter on tf file count number', async () => {
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: