Skip to content

[O2B-1443] Add filter on CTF, TF and Other File counts for runs-overview page#1900

Merged
graduta merged 3 commits intomainfrom
feature/O2B-1443/add-ctf-tf-filter-run
May 20, 2025
Merged

[O2B-1443] Add filter on CTF, TF and Other File counts for runs-overview page#1900
graduta merged 3 commits intomainfrom
feature/O2B-1443/add-ctf-tf-filter-run

Conversation

@graduta
Copy link
Copy Markdown
Member

@graduta graduta commented May 20, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • adds filtering based on CTF, TF and Other File counts in the Filter Popup

Notable changes for developers:

Changes made to the database:

@graduta graduta requested a review from Copilot May 20, 2025 14:46
@graduta graduta self-assigned this May 20, 2025
@graduta graduta requested a review from martinboulais as a code owner May 20, 2025 14:46
@codecov
Copy link
Copy Markdown

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.77%. Comparing base (ebdbdc6) to head (24e1178).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
+ Coverage   44.62%   44.77%   +0.15%     
==========================================
  Files        1018     1018              
  Lines       17124    17123       -1     
  Branches     3089     3087       -2     
==========================================
+ Hits         7641     7667      +26     
+ Misses       9483     9456      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds filtering capabilities on CTF, TF, and Other file counts for the runs overview page.

  • Introduces new filter parameters in the DTO and use case
  • Updates backend logic to apply the new filters
  • Adds frontend models, active columns, and tests for CTF/TF filters

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/lib/usecases/run/GetAllRunsUseCase.test.js Added tests for CTF and TF file count filters
lib/usecases/run/GetAllRunsUseCase.js Applied filtering logic for ctfFileCount, tfFileCount, otherFileCount
lib/public/views/Runs/Overview/RunsOverviewModel.js Registered numerical filters for the new file count fields
lib/public/views/Runs/ActiveColumns/runsActiveColumns.js Enabled filter widgets and display classes for the new columns
lib/domain/dtos/filters/RunFilterDto.js Extended the RunFilterDto schema with ctfFileCount, tfFileCount, otherFileCount
Comments suppressed due to low confidence (1)

@graduta graduta requested a review from Copilot May 20, 2025 15:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds filtering capabilities for CTF, TF, and Other file counts on the runs-overview page.

  • Introduces new ctfFileCount, tfFileCount, and otherFileCount filter parameters in the backend use case and DTO
  • Adds corresponding filter models and active columns in the frontend UI
  • Extends unit tests to cover filtering logic for CTF and TF file counts

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/lib/usecases/run/GetAllRunsUseCase.test.js Added tests for CTF and TF file count filters
lib/usecases/run/GetAllRunsUseCase.js Refactored file‐count filters into a loop; added new filter fields
lib/public/views/Runs/Overview/RunsOverviewModel.js Registered new numerical filters for CTF, TF, and Other file counts
lib/public/views/Runs/ActiveColumns/runsActiveColumns.js Added columns and filter hooks for the new file count fields
lib/domain/dtos/filters/RunFilterDto.js Extended the RunFilterDto schema to include CTF, TF, and Other counts
Comments suppressed due to low confidence (1)

test/lib/usecases/run/GetAllRunsUseCase.test.js:614

  • Tests cover CTF and TF filters but there’s no test for otherFileCount. Add a similar test case for otherFileCount to ensure the new filter is properly exercised.
it('should successfully filter on tf file count number', async () => {

@graduta graduta merged commit 6e60c78 into main May 20, 2025
24 checks passed
@graduta graduta deleted the feature/O2B-1443/add-ctf-tf-filter-run branch May 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants