Skip to content

[O2B-1548] Migrate qc flag types overview model to use filtering model pattern#2100

Merged
graduta merged 75 commits intomainfrom
improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern
Apr 17, 2026
Merged

[O2B-1548] Migrate qc flag types overview model to use filtering model pattern#2100
graduta merged 75 commits intomainfrom
improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 9, 2026 •
edited by graduta
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • The 'bad' filter has been changed from multiple choice selection boxes to a collection of three radio buttons stating:
    • Bad
    • Not bad
    • Any

Notable changes for developers:

  • The qcFlagOverviewModel file now stores its filters in a FilteringModel instance.
  • The previous filters must now be accessed through the FilteringModel.get function

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
chore: remove redundant model assignment.
722caf7
chore: move all filters denoted as so to a filteringModel
f161cae
Make filterInputModel extend filterModel
9faffaf
rename inputfilter to ParsedInputFilter
247943b
implement authorfilter with ParsedInputFilterModel changes
114285d
re-implement filter
f39f7ae
add tag-filters to the filtering object
df1fea3
replace titleFilter and contentFilter with RawTextFilterModels
96ca85f
make Authorfilter an implementation of RawTextFilterModel
93b3291
add runs filter to the filteringmodel
5a5e830
add environments filter to the filteringmodel
b5e7148
add lhcFills filter to the filteringmodel
3507ba0
add created filter to the filteringmodel
9c63409
move the sort 'filter' to fetchlogs, since it doesn't actually filter…
5500b3e 
… anything
change filter to rawTextFilter for title
a09ae8b
fix test by changing event type to 'change'
512999b
fix content and author tests
0f15812
import openFilteringPanel and resetFilters
7b641ca
fix createdAt filter test
5ab8218
change event types to change
4c96d73
fix isAnyFilterActive
18ce4dc
remove _raw as from authorfilterModel, as it serves no purpose
685dd38
chore: removed ParsedInputFilterModel
4e132fd
chore: add toLowerCase to filterQueryParam computation
caf9812
@NarrowsProjects
[O2B-1530] Lhc fills add sb duration filter (#2080)
41c5a72 
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
@isaachilly
[O2B-1544] Fix pagination for filtered envs and add a test (#2096)
f38f597 
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
remove the combination operator from runs
3efdf1d
remove the combination operator from envirionments
fc61bea
remove the combination operator from lhcFills
9c4df68
make filter computation much more compact using filteringmodel.normalize
b860320
NarrowsProjects and others added 25 commits April 13, 2026 17:12
check runnumber fill number and lhc period for existence rather than …
82ff985 
…for length
undo test comments
1574c4d
chore rename reset to clear()
0bcf334
make overview test more efficient with beforeEach
7731fd3
test: remove unneeded OpenFilterPanel calls
3bf7e66
remove takescreenshot
906674f
Remove unneeded javadoc params
a760812
chore: change the with margins to roughly span the filters the entire…
3addfc7 
… filter popover
test: add happy-flow rootOnly test
85b9473
test: add log sorting tests for runs and for envirionments
e711fe9
reduce the width of the author filter component
4fa1173
chore removed unneeded length checks from should successfully filter …
88db5d8 
…by rootOnly
chore: remove the needless 'limit' part of the rootOnly logs test
da4caf5
@NarrowsProjects
Merge branch 'main' into improv/O2B-1534/Migrate-Log-Overview-to-use-…
c768ba5 
…FilteringModel-pattern
feat: create textInputFilter
39df769
chore: replace runNumbersFilter and rawTextFileters with logsActiveCo…
f095cce 
…lumns
feat: add a width argument to textinputFIlter
6fec661
replace the rest of the rawTextFilters
e095876
update tests to function with the new textInput components
033ff35
fix failing tests
a40f51f
chore: delete fillNumbersFilter createdFilter, logs/environmentFilter…
fa83c7f 
…, runs/environmentFilter and schemeNameFilter
undo incorrect return description of the author component jsdoc
5216900
chore: improve the jsdoc of selectionmodel
3d35206
Merge branch 'improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringMo…
d37463c 
…del-pattern' into improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern
make textFitler calls oneliners
a7df032
Base automatically changed from improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern to main April 17, 2026 07:36
@graduta graduta merged commit 37b6ee1 into main Apr 17, 2026
23 of 24 checks passed
@graduta graduta deleted the improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern branch April 17, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

@isaachilly isaachilly Awaiting requested review from isaachilly

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NarrowsProjects @graduta @isaachilly