Skip to content

[O2B-1569] Fix duplicated requests sent by front-end for runs-per-data-pass page#2109

Merged
graduta merged 10 commits intomainfrom
improv/BKP/O2B-1569/reduce-loading-times-on-runs-per-data-pass
Mar 12, 2026
Merged

[O2B-1569] Fix duplicated requests sent by front-end for runs-per-data-pass page#2109
graduta merged 10 commits intomainfrom
improv/BKP/O2B-1569/reduce-loading-times-on-runs-per-data-pass

Conversation

@graduta
Copy link
Member

@graduta graduta commented Mar 12, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • improvements in loading times of page runs-per-data-pass

Notable changes for developers:

  • request GET dataPass for specific id is sent 2 times instead of one because of pagination observer and initial loading page;
  • because of the double fetching, the summary request of QC periods is done also 2 times. Moreover, for each of the 2 times, the observer kicks in and does another 2 same requests, bringing the total to 4 summary requests fetching the same data in parallel (not even in sequence so that the browser can use its cache mechanism)
  • registration of events was moved to load methods as otherwise they will trigger in constructor (at load of application)
  • rename of miss-spelled words
  • total requests now down to 9 from 17 and loading times of all requests together for runs-per-data-pass halved

Changes made to the database:

@graduta graduta requested a review from isaachilly March 12, 2026 10:41
@graduta graduta self-assigned this Mar 12, 2026
@graduta graduta changed the title [O2B-1569] Fixes big SQL query on back-end and duplicated requests sent by front-end [O2B-1569] Fix duplicated requests sent by front-end for runs-per-data-pass page Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.52%. Comparing base (0977d77) to head (1357cd3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 27 Missing ⚠️
...mulationPass/RunsPerSimulationPassOverviewModel.js 0.00% 7 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 6 Missing ⚠️
lib/public/views/Runs/RunsModel.js 0.00% 4 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   45.55%   45.52%   -0.04%     
==========================================
  Files        1044     1044              
  Lines       17327    17341      +14     
  Branches     3140     3143       +3     
==========================================
  Hits         7894     7894              
- Misses       9433     9447      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta merged commit 6ff81d8 into main Mar 12, 2026
23 of 26 checks passed
@graduta graduta deleted the improv/BKP/O2B-1569/reduce-loading-times-on-runs-per-data-pass branch March 12, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants