Skip to content

Document unobvious plugin call trigger/await decisions #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justonedev1 merged 1 commit into from
May 7, 2026
Merged

Document unobvious plugin call trigger/await decisions #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions workflows/readout-dataflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1854,7 +1854,7 @@ roles:
- name: pfr
call:
func: dcs.PrepareForRun()
trigger: before_CONFIGURE
trigger: before_CONFIGURE # PFR cannot be moved earlier because it would increase unreasonably deployment failures timeouts. To be revisited if/when we have a way to abort DCS PFR executions.
await: after_CONFIGURE-1
timeout: "{{ dcs_pfr_timeout }}"
critical: false
Expand Down Expand Up @@ -1888,7 +1888,7 @@ roles:
- name: initialize
call:
func: ddsched.PartitionInitialize()
trigger: before_CONFIGURE
trigger: before_CONFIGURE # this has to run in parallel with STFSenders CONFIGURE
await: after_CONFIGURE-1
timeout: "{{ ddsched_initialize_timeout }}"
critical: true
Expand Down Expand Up @@ -1928,7 +1928,7 @@ roles:
- name: configure
call:
func: odc.Configure()
trigger: after_CONFIGURE-1
trigger: after_CONFIGURE-1 # it's started only once stfsenders are in CONFIGURED, so TFBuilder does not produce errors when connecting to STFSenders. However, TFBuilder would eventually connect anyway, so there is no strong justification for delaying this. See OCTRL-607.
await: after_CONFIGURE-1
timeout: "{{ odc_configure_timeout }}"
critical: true
Expand Down
Loading