use grpc++ instead of grpc++_unsecure#189
Merged
lkrcal merged 1 commit intoAliceO2Group:devfrom Apr 24, 2025
Merged
Conversation
With the recent grpc bump, grpc causes troubles when both grpc and grpc_unsecure are loaded by the same binary. Here, it is the case when StfSender and StfBuilder load the OccLite plugin (which uses grpc). This change fixes both and allows them to be controlled by ECS again, tested on a VM setup with FLP suite. I do not know if it might break DataDistribution in some other context, I hope that anyone reviewing it may know...
Contributor
Author
|
@lkrcal could you have a look please? |
Member
|
@lkrcal could we get a tag with this ? Then we could install it and in case this breaks something we revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent grpc bump, grpc causes troubles when both grpc and grpc_unsecure are loaded by the same binary. Here, it is the case when StfSender and StfBuilder load the OccLite plugin (which uses grpc). This change fixes both and allows them to be controlled by ECS again. I tested it on a VM setup with FLP suite.
I do not know if it might break DataDistribution in some other context, I hope that anyone reviewing it may know...