Skip to content

Align DetectorK to Ruben's latest#69

Merged
njacazio merged 2 commits intoAliceO2Group:masterfrom
njacazio:nj-dev-its2-lut
Jun 3, 2021
Merged

Align DetectorK to Ruben's latest#69
njacazio merged 2 commits intoAliceO2Group:masterfrom
njacazio:nj-dev-its2-lut

Conversation

@njacazio
Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio
Copy link
Copy Markdown
Collaborator Author

@preghenella Ruben suggested that we update the code with his latest changes for the TPC, if you agree with the changes I let you merge

@njacazio njacazio requested a review from preghenella May 31, 2021 13:55
@njacazio njacazio force-pushed the nj-dev-its2-lut branch 2 times, most recently from f1cc534 to 6283ccd Compare June 1, 2021 05:36
@preghenella
Copy link
Copy Markdown
Collaborator

ciao @njacazio
sorry, there are too many changes and some of them are touching updates I did to improve the program.
We cannot accept this PR.
Can you please either open a new PR or just extract what is strictly needed for the ITS2?

njacazio added 2 commits June 3, 2021 09:32
- Align to shahor02/FT1rs@47dc282
* The MS was accounted on the for the materials between the TPC and ITS but not the e.loss (the xrho = 0 was passed).
* The addition of padrows as layers was done in a wrong way, phiResMean was passed instead of the rrho=0
- shahor02/FT1rs@da11fdf
* Recalculated all 3 passive layers between the ITS and TPC active ones using current O2 geometry
@njacazio njacazio merged commit 32dde1a into AliceO2Group:master Jun 3, 2021
@njacazio
Copy link
Copy Markdown
Collaborator Author

njacazio commented Jun 3, 2021

Hi, done! Merging this simplified version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants