infoLogger new cmake #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sy-c
commented
Dec 5, 2018
sy-c
commented
- cmake rewritten
- targets exported
- swig wrapper code generated by cmake
- added interface to Go
Collaborator
Author
|
awegrzyn
reviewed
Dec 7, 2018
Collaborator
awegrzyn
left a comment
awegrzyn
left a comment
There was a problem hiding this comment.
Hi, it looks good, as it's a large PR I was not able to test everything, here are my few comments:
- I'd move binaries into
build/bindirectory:set(EXECUTABLE_OUTPUT_PATH "${CMAKE_BINARY_DIR}/bin") make testclaims "No tests were found!!!"- Compile definitions are not set, eg:
_WITH_MYSQLwhen MySQL found
| ENDIF () | ||
| endforeach () | ||
| # global compilation options | ||
| set(CMAKE_CXX_STANDARD 14) |
Collaborator
There was a problem hiding this comment.
I'd not enforce C++14, if a dependency uses C++17-enabled features in its interfaces the compilation will fail.
As aliBuild also sets C++ version I think simple check, as in QC, would be good: https://github.com/AliceO2Group/QualityControl/blob/48265588da0696fabf01b4a27aef50bfbf67de9d/CMakeLists.txt#L59
CMakeLists.txt
Outdated
| src/infoLoggerMessageDecode.c | ||
| src/InfoLoggerMessageHelper.cxx | ||
| src/InfoLoggerMessageList.cxx | ||
| ${INFOLOGGERSERVER_SRC_EXTRA} |
Collaborator
There was a problem hiding this comment.
This could be replaced by generator expression:
$<$<BOOL:${MYSQL_FOUND}>:src/InfoLoggerDispatchSQL.cxx>
Collaborator
Author
|
Hello Adam, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.