[SimWF] Update reco and sources#1441
Conversation
|
The initial motivation for this PR was to enable (disable) TOF when present (not present). Additional detector logic will be added - if needed - after this PR. |
c64e9ae to
ef23c45
Compare
c349bb5 to
d2d25f4
Compare
|
Hello @shahor02 export ALIEN_JDL_LPMANCHORPASSNAME=apass2
export ALIEN_JDL_MCANCHOR=apass2
export ALIEN_JDL_COLLISIONSYSTEM=Pb-Pb
export ALIEN_JDL_CPULIMIT=8
export ALIEN_JDL_LPMPASSNAME=apass2
#export ALIEN_JDL_LPMRUNNUMBER=544121
export ALIEN_JDL_LPMRUNNUMBER=544091
export ALIEN_JDL_LPMPRODUCTIONTYPE=MC
export ALIEN_JDL_LPMINTERACTIONTYPE=PbPb
export ALIEN_JDL_LPMPRODUCTIONTAG=LHC24a1
#export ALIEN_JDL_LPMANCHORRUN=544121
export ALIEN_JDL_LPMANCHORRUN=544091
export ALIEN_JDL_LPMANCHORPRODUCTION=LHC22o
export ALIEN_JDL_LPMANCHORYEAR=2023
export NTIMEFRAMES=2
export NSIGEVENTS=2
export SPLITID=100
export PRODSPLIT=153
export CYCLE=0
# on the GRID, this is set, for our use case, we can mimic any job ID
export ALIEN_PROC_ID=2963436952
# run the central anchor steering script; this includes
# * derive timestamp
# * derive interaction rate
# * extract and prepare configurations (which detectors are contained in the run etc.)
# * run the simulation (and QC)
${O2DPG_ROOT}/MC/run/ANCHOR/anchorMC.shthis PR with AliceO2Group/AliceO2#12686, I see TOF being included in the Let me know if you need more details of course. |
b67d516 to
cadddbf
Compare
| export RUN_DURATION=`cat Duration.txt` | ||
| export RUN_BFIELD=`cat BField.txt` | ||
| export RUN_DETECTOR_LIST=`cat DetList.txt` | ||
| export WORKFLOW_DETECTORS=$(echo "$RUN_DETECTOR_LIST" | tr " " ",") |
There was a problem hiding this comment.
@shahor02 With this I can make it work. Does that make sense?
Now, only the used detectors of this run are used and then setenv.sh puts things together correctly.
There was a problem hiding this comment.
@benedikt-voelkel surely it will work but it redefines the WORKFLOW_DETECTORS set from the JDL. It is up to DPG (@chiarazampolli @noferini ) to decide if they want to have a variable detectors list going into the reconstruction in the same period. This may alter the output files from reco which in turn may affect some postprocessing / merging etc.
The alternative could be to deactivate in the MC detectors present in the WORKFLOW_DETECTORS and absent in the RUN_DETECTOR_LIST
e039aab to
3492313
Compare
|
So, after another discussion with @shahor02 and @chiarazampolli I ended up implementing the following approach: The activeDetectors = anchorConfig.get('o2-ctf-reader-workflow-options').get('onlyDet','all')These are by default all detectors or the list that has been passed to Now, with the work from @sawenzel (#1452), we in addition pull the list of actually used detectors in data taking from CCDB. I then build the intersection of those lists, hence respecting the choice from a user steering the simulation ( This is then the detector list that will be passed to the transport and only those detectors will produce hit files. Indeed, that might introduce some computational overhead, on the other hand it circumvents the following problem: |
3492313 to
a6faef1
Compare
|
@noferini for run |
Hi @benedikt-voelkel , I checked in the RCT and the list is this one |
Exactly, since |
|
Very good. Do you need to change something else or can we merge the PR? here you have TOF but not TRD. I am not in the approver list, pinging @chiarazampolli |
|
Let's wait for the CI and then we should be fine. I check your suggested run (544167) and I get the same list 👌 And most importantly, the simulation (and QC) goes though. |
a6faef1 to
1ba7a69
Compare
* always run all digi stages independent of which detectors produce hits
* update TOF match sources
* add TRD and HMP sources
* introduces implicit modularisation
* empty digit and reco files are always produced for missing detector
hit files
--> technicannly allows for any detector composition
--> in particular crucial for anchored simulations
--> enables the simulation of single detectors for specific expert
studies when other material budget is not needed or has to be
avoided even
* do not hard-code ALIEN_JDL_WORKFLOWDETECTORS but actually allow to
take it from the outside JDL in anchorMC.sh
1ba7a69 to
9fda483
Compare
* always run all digi stages independent of which detectors produce hits
* run all reco and match stages on top of that
* update TOF match sources
* add TRD and HMP sources
* introduces implicit modularisation
* empty digit and reco files are always produced for missing detector
hit files
--> technicannly allows for any detector composition
--> in particular crucial for anchored simulations
--> enables the simulation of single detectors for specific expert
studies when other material budget is not needed or has to be
avoided even
* do not hard-code ALIEN_JDL_WORKFLOWDETECTORS but actually allow to
take it from the outside JDL in anchorMC.sh
Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
* always run all digi stages independent of which detectors produce hits
* run all reco and match stages on top of that
* update TOF match sources
* add TRD and HMP sources
* introduces implicit modularisation
* empty digit and reco files are always produced for missing detector
hit files
--> technicannly allows for any detector composition
--> in particular crucial for anchored simulations
--> enables the simulation of single detectors for specific expert
studies when other material budget is not needed or has to be
avoided even
* do not hard-code ALIEN_JDL_WORKFLOWDETECTORS but actually allow to
take it from the outside JDL in anchorMC.sh
Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
* always run all digi stages independent of which detectors produce hits
* run all reco and match stages on top of that
* update TOF match sources
* add TRD and HMP sources
* introduces implicit modularisation
* empty digit and reco files are always produced for missing detector
hit files
--> technicannly allows for any detector composition
--> in particular crucial for anchored simulations
--> enables the simulation of single detectors for specific expert
studies when other material budget is not needed or has to be
avoided even
* do not hard-code ALIEN_JDL_WORKFLOWDETECTORS but actually allow to
take it from the outside JDL in anchorMC.sh
Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
always run all digi stages independent of which detectors produce hits
update TOF match sources
add TRD and HMP sources
introduces implicit modularisation
hit files
--> technicannly allows for any detector composition
--> in particular crucial for anchored simulations
--> enables the simulation of single detectors for specific expert
studies when other material budget is not needed or has to be
avoided even
do not hard-code ALIEN_JDL_WORKFLOWDETECTORS but actually allow to
take it from the outside JDL in anchorMC.sh