Skip to content

[AnchorMC] Allow for any additional option for sim WF#1463

Merged
benedikt-voelkel merged 1 commit intoAliceO2Group:masterfrom
benedikt-voelkel:anchor
Feb 19, 2024
Merged

[AnchorMC] Allow for any additional option for sim WF#1463
benedikt-voelkel merged 1 commit intoAliceO2Group:masterfrom
benedikt-voelkel:anchor

Conversation

@benedikt-voelkel
Copy link
Copy Markdown
Contributor

@benedikt-voelkel benedikt-voelkel commented Feb 15, 2024

Use as ALIEN_JDL_ANCHOR_SIM_OPTIONS="-ini <ini_file> -confKey
"key=value;otherKey=otherValue" -trigger <trigger_file>
-productionTag myTag"

Build the final remainingargs by prepedning it.

The last argument wins, hence in this case -productionTag would not be
overwritten with this user choice

@benedikt-voelkel
Copy link
Copy Markdown
Contributor Author

@benedikt-voelkel benedikt-voelkel force-pushed the anchor branch 2 times, most recently from f6e2c2f to 901a0c8 Compare February 15, 2024 12:53
@benedikt-voelkel benedikt-voelkel marked this pull request as ready for review February 15, 2024 14:09
@benedikt-voelkel
Copy link
Copy Markdown
Contributor Author

As an example, I tested with

ALIEN_JDL_SIM_OPTIONS="-gen external -proc cdiff -ini ${O2DPG_ROOT}/MC/config/PWGLF/ini/GeneratorLFStrangenessTriggered.ini"

and it runs through just fine.

Use as ALIEN_JDL_SIM_OPTIONS="-ini <ini_file> -confKey
"key=value;otherKey=otherValue" -trigger <trigger_file>
-productionTag myTag"

Build the final remainingargs by prepedning it.

The last argument wins, hence in this case -productionTag would not be
overwritten with this user choice
@benedikt-voelkel
Copy link
Copy Markdown
Contributor Author

@chiarazampolli
What would be your opinion on this? If you agree, I would merge it.
In addition, I will finally take care to add this and some other PRs to be ported back for 2022.

@sawenzel
Copy link
Copy Markdown
Contributor

Note that the name was changed to ALIEN_JDL_ANCHOR_SIM_OPTIONS. Better to adapt the comments in this PR.

@benedikt-voelkel
Copy link
Copy Markdown
Contributor Author

Done. When we merge, we can change the commit message accordingly

@chiarazampolli
Copy link
Copy Markdown
Collaborator

Hello,

I think we cannot have "_" in the JDL var, so ALIEN_JDL_ANCHOR_SIM_OPTIONS should be ALIEN_JDL_ANCHORSIMOPTIONS. @costing can you confirm? Some time ago it was like this.

Chiara

@costing
Copy link
Copy Markdown

costing commented Feb 19, 2024

Ciao Chiara,

With the current code it is no longer a problem.

Tested with this job that produced this output. So underscores are no longer an issue.

Cheers,

.costin

@chiarazampolli
Copy link
Copy Markdown
Collaborator

Good to know, thanks!

Chiara

benedikt-voelkel added a commit to benedikt-voelkel/O2DPG that referenced this pull request Feb 19, 2024
)

Use as ALIEN_JDL_ANCHOR_SIM_OPTIONS="-ini <ini_file> -confKey
"key=value;otherKey=otherValue" -trigger <trigger_file>
-productionTag myTag"

Build the final remainingargs by prepending it.

The last argument wins, hence in this case -productionTag would not be
overwritten with this user choice

Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
noferini pushed a commit that referenced this pull request Feb 19, 2024
Use as ALIEN_JDL_ANCHOR_SIM_OPTIONS="-ini <ini_file> -confKey
"key=value;otherKey=otherValue" -trigger <trigger_file>
-productionTag myTag"

Build the final remainingargs by prepending it.

The last argument wins, hence in this case -productionTag would not be
overwritten with this user choice

Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
benedikt-voelkel added a commit that referenced this pull request Feb 20, 2024
Use as ALIEN_JDL_ANCHOR_SIM_OPTIONS="-ini <ini_file> -confKey
"key=value;otherKey=otherValue" -trigger <trigger_file>
-productionTag myTag"

Build the final remainingargs by prepending it.

The last argument wins, hence in this case -productionTag would not be
overwritten with this user choice

Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants