Skip to content

Change eta cut for TPC tracks in GLO QC.#1487

Merged
noferini merged 1 commit intoAliceO2Group:masterfrom
mfaggin:fixEtaTPCCut
Feb 21, 2024
Merged

Change eta cut for TPC tracks in GLO QC.#1487
noferini merged 1 commit intoAliceO2Group:masterfrom
mfaggin:fixEtaTPCCut

Conversation

@mfaggin
Copy link
Copy Markdown
Contributor

@mfaggin mfaggin commented Feb 21, 2024

No description provided.

@mfaggin
Copy link
Copy Markdown
Contributor Author

mfaggin commented Feb 21, 2024

Hi @noferini @chiarazampolli @benedikt-voelkel this is the modification discussed this morning at the DPG corodination meeting.

However, we cannot put any lable on it because we do not have the permissions (the Label field in the right sidebar is not clickable for us)

@noferini
Copy link
Copy Markdown
Collaborator

noferini commented Feb 21, 2024 •
edited
Loading

Done
For the next time you can follow @benedikt-voelkel suggestion in slide 4
https://indico.cern.ch/event/1385445/contributions/5828895/attachments/2805533/4895407/20240221_slides.pdf

Example comment: “+async-label mc data 2023-pbpb-apass”

noferini
noferini approved these changes Feb 21, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@noferini noferini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial PR

@noferini noferini enabled auto-merge (squash) February 21, 2024 15:56
@noferini
Copy link
Copy Markdown
Collaborator

noferini commented Feb 21, 2024

Hi @mfaggin , I removed the label for pp 2022 apass6.
I would leave only the one for Pb-Pb since pp apass6 date reco was already done and I would keep the same config for DATA and MC.
Do you agree?

@mfaggin
Copy link
Copy Markdown
Contributor Author

mfaggin commented Feb 21, 2024

Hi @mfaggin , I removed the label for pp 2022 apass6. I would leave only the one for Pb-Pb since pp apass6 date reco was already done and I would keep the same config for DATA and MC. Do you agree?

ciao Francesco, since the apass6 is already done then yes, nothing against it

@noferini noferini merged commit 62aaa86 into AliceO2Group:master Feb 21, 2024
chiarazampolli pushed a commit that referenced this pull request Mar 11, 2024
@mfaggin @chiarazampolli
Change eta cut for TPC tracks in GLO QC. (#1487)
756f93c 
Co-authored-by: Mattia Faggin <mfaggin@alipap1.cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request Apr 26, 2024
@mfaggin
Change eta cut for TPC tracks in GLO QC. (#1487)
b68c7d1 
Co-authored-by: Mattia Faggin <mfaggin@alipap1.cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request Apr 26, 2024
@mfaggin
Change eta cut for TPC tracks in GLO QC. (#1487)
0d953a4 
Co-authored-by: Mattia Faggin <mfaggin@alipap1.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noferini noferini noferini approved these changes

@chiarazampolli chiarazampolli chiarazampolli approved these changes

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

@gconesab gconesab Awaiting requested review from gconesab

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@martenole martenole Awaiting requested review from martenole

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfaggin @noferini @chiarazampolli @benedikt-voelkel