Fix mishandling of TMPDIR #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMPDIR is used on many system for the user's temporary dir. Overriding it and deleting has unwanted consequence that any subsequent usage might fail, e.g. on macOS this happens when trying to create FairMQ channels which are backed by unix domain sockets in $TMPDIR. I suspect ROOT would also have troubles with it for some operations, even on linux.
sawenzel
approved these changes
May 3, 2022
Member
Author
|
Error unrelated. Tested locally. Merging. |
1 similar comment
Member
Author
|
Error unrelated. Tested locally. Merging. |
rmunzer
pushed a commit
to rmunzer/O2DPG
that referenced
this pull request
May 11, 2022
TMPDIR is used on many system for the user's temporary dir. Overriding it and deleting has unwanted consequence that any subsequent usage might fail, e.g. on macOS this happens when trying to create FairMQ channels which are backed by unix domain sockets in $TMPDIR. I suspect ROOT would also have troubles with it for some operations, even on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TMPDIR is used on many system for the user's temporary dir. Overriding
it and deleting has unwanted consequence that any subsequent usage might
fail, e.g. on macOS this happens when trying to create FairMQ channels
which are backed by unix domain sockets in $TMPDIR. I suspect ROOT would
also have troubles with it for some operations, even on linux.