Skip to content

Conversation

@gconesab
Copy link
Collaborator

No description provided.

@preghenella preghenella merged commit b67c0cf into AliceO2Group:master Nov 19, 2020
miranov25 pushed a commit to miranov25/O2DPG that referenced this pull request Dec 12, 2025
New features:
- get_required_branches() public method for branch detection
- AST-based selection string parsing (_parse_selection_columns)
- Alias chain resolution to base branches (_resolve_to_base_branches)
- Regex fallback for unparseable expressions
- validate=True filters to existing branches (lazy & eager modes)

Design decisions (unanimous reviewer approval):
- (a) AST parsing for accuracy with physics expressions
- (b) Filter function names from results (np, sqrt, abs, etc.)
- (a) Raise error on circular aliases
- (a) Public API for user debugging

GPT tweaks implemented:
- AliceO2Group#1: Get ALL columns from expr, not just aliases
- AliceO2Group#2: Shared _visited set with add/remove pattern
- AliceO2Group#3: validate works in both lazy AND eager modes
- AliceO2Group#4: Helper methods kept private

Tests: 51 new tests, 1014 total passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants