MFT: Fixing the json selection#533
Merged
martenole merged 1 commit intoAliceO2Group:masterfrom Jul 13, 2022
Merged
Conversation
tomas-herman
requested review from
chiarazampolli,
davidrohr,
martenole and
shahor02
as code owners
martenole
approved these changes
Jul 13, 2022
Contributor
martenole
left a comment
martenole
left a comment
There was a problem hiding this comment.
Fine with me, but this does not change the logic, right? It only removes the duplicate setting of the QC json in case MFT RECO is disabled?
Contributor
Author
|
Hi, yes the logic is the same. But I noticed that the selection was not working for us which I assume was because of the extra line. Now the implementation is exactly the same as for TOF/MCH/MID for which the selection seems to be working fine. |
martenole
reviewed
Jul 13, 2022
| if [[ $EPNSYNCMODE == 1 || "0$GEN_TOPO_LOAD_QC_JSON_FROM_CONSUL" == "01" ]]; then | ||
| [[ -z "$QC_JSON_TPC" ]] && QC_JSON_TPC=consul://o2/components/qc/ANY/any/tpc-full-qcmn | ||
| [[ -z "$QC_JSON_ITS" ]] && QC_JSON_ITS=consul://o2/components/qc/ANY/any/its-qcmn-epn-full | ||
| [[ -z "$QC_JSON_MFT" ]] && QC_JSON_MFT=consul://o2/components/qc/ANY/any/mft-full-qcmn |
Contributor
There was a problem hiding this comment.
Ah right, because when you set QC_JSON_MFT here then the check below [[ -z $QC_JSON_MFT ]] is false and therefore you don't use the mft-track-full-qcmn even if MFT_RECO is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.