Skip to content

Update RICH tables and PID QA task#101

Merged
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
njacazio:nj-a3-frich
Sep 21, 2021
Merged

Update RICH tables and PID QA task#101
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
njacazio:nj-a3-frich

Conversation

@njacazio
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread ALICE3/Tasks/pidRICHqa.cxx Outdated
Comment on lines +148 to +155
histos.add(rich "/TrackSelection", "", kTH1F, {{10, 0.5, 10.5}}); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(1, "Tracks read"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(2, "Passed RICH"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(3, "Passed TOF"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(4, "Passed minLength"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(5, "Passed maxLength"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(6, "Passed eta"); \
histos.get<TH1>(HIST(rich "/TrackSelection"))->GetXaxis()->SetBinLabel(7, "Passed PDG"); \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi
the add() functions of the histogram registry now also return a pointer to the respective histogram
so one could simplify this part a bit (in case you find it more readable) by using

{
  auto trackSelHist = std::get<std::shared_ptr<TH1>>(histos.add(rich "/TrackSelection", "", kTH1F, {{10, 0.5, 10.5}}));
  trackSelHist->GetXaxis()->...
  ...
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mario, indeed thanks a lot, however I personally don't find it particularly more elegant as I still have to cast it to TH1. I might consider it for the future, thanks a lot!

@jgrosseo jgrosseo merged commit 949443a into AliceO2Group:master Sep 21, 2021
@njacazio njacazio deleted the nj-a3-frich branch September 22, 2021 15:49
njacazio pushed a commit that referenced this pull request Apr 20, 2023
* Add option to process only tracked cascades

* Please consider the following formatting changes (#101)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants