[PWGCF,PWGLF] adding ITS PID and other minor changes #10171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiatomassini
requested review from
ChiaraDeMartin95,
alibuild,
ariedel-cern,
ercolessi,
lauraser,
lgraczykCern,
njacazio,
otonvd,
prchakra,
saganatt,
shouqiye,
skundu692,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
njacazio
approved these changes
Feb 24, 2025
Collaborator
|
Thanks |
Collaborator
|
Maybe pow can be still avoided |
Collaborator
|
Dear @victor-gonzalez Could you please take a look and approve the changes. Thank you. Gleb and Sofia. |
victor-gonzalez
approved these changes
Feb 24, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, for the next iterations, follow linter recommendations on avoiding the use of TDatabasePDG and on using std:: for names from the std namespace. Please also use named constants from TPDGCode.h, and, if needed, PhysicsConstants.h, instead of plain numbers for particle codes. And don't forget to remove commented code
njacazio
pushed a commit
that referenced
this pull request
Apr 11, 2025
Co-authored-by: Sofia Tomassini <sofia.tomassini@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@njacazio @glromane