Skip to content

[PWGHF] Add track quality selection for D0 candidate selector, add track quality axis in Thn for taskD0#10367

Merged
fcatalan92 merged 12 commits intoAliceO2Group:masterfrom
Mingyu3360715:master
Mar 14, 2025
Merged

[PWGHF] Add track quality selection for D0 candidate selector, add track quality axis in Thn for taskD0#10367
fcatalan92 merged 12 commits intoAliceO2Group:masterfrom
Mingyu3360715:master

Conversation

@Mingyu3360715
Copy link
Contributor

The track quality selection is added in D0 candidate selector as a simple filter, without changing any existing table structure.
The ITS cluster found and TPC crossed rows information is added into the ThnSparse with configurable option, for the purpose of analysis under different track quality selections in a single train run.
Modifications are tested both with data and MC, results are shown below. The modification works as expected.
Screenshot from 2025-03-06 18-56-33
Screenshot from 2025-03-06 18-56-14
Screenshot from 2025-03-06 18-55-45
Screenshot from 2025-03-06 19-03-15

@github-actions github-actions bot added the pwghf PWG-HF label Mar 6, 2025
@github-actions github-actions bot changed the title PWGHF: Add track quality selection for D0 candidate selector, add track quality axis in Thn for taskD0 [PWGHF] Add track quality selection for D0 candidate selector, add track quality axis in Thn for taskD0 Mar 6, 2025
@Mingyu3360715
Copy link
Contributor Author

Mingyu3360715 commented Mar 6, 2025

Hi @fcatalan92 , @vkucera ,
sorry that I accidentally overwrote the previous PR, but I have taken your advice to avoid changes on the existing table structure, only leaving some "local" modifications and make it correctly compiled.
Besides, to avoid running the wagon multiple times on large data sample for systematic uncertainty studies, some of the track quality values are stored in extra axes in the output Thn, which is configurable.

@alibuild
Copy link
Collaborator

alibuild commented Mar 6, 2025

Error while checking build/O2Physics/o2 for 47e3f8e at 2025-03-06 20:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10367-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:307:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linter issues.

fcatalan92
fcatalan92 previously approved these changes Mar 12, 2025
@fcatalan92 fcatalan92 enabled auto-merge (squash) March 12, 2025 08:43
@fcatalan92
Copy link
Collaborator

@vkucera Could you check if this PR is fine for you now?

@vkucera
Copy link
Collaborator

vkucera commented Mar 12, 2025

@vkucera Could you check if this PR is fine for you now?

I'm waiting for the O2 linter issues to be fixed.

auto-merge was automatically disabled March 14, 2025 11:14

Head branch was pushed to by a user without write access

@Mingyu3360715
Copy link
Contributor Author

@vkucera Could you check if this PR is fine for you now?

I'm waiting for the O2 linter issues to be fixed.

Hi @vkucera , I have fixed the O2 linter issues that was left by someone before. But the MegaLinter issue seems not caused by my commit. When you have time, could you please have a look and approve it if it is ok for you? Thanks a lot.

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mingyu3360715 for resolving the issues.

@fcatalan92 fcatalan92 enabled auto-merge (squash) March 14, 2025 14:10
@fcatalan92 fcatalan92 merged commit 2bad958 into AliceO2Group:master Mar 14, 2025
13 of 15 checks passed
lubynets pushed a commit to lubynets/O2Physics that referenced this pull request Mar 22, 2025
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
njacazio pushed a commit that referenced this pull request Apr 11, 2025
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Apr 15, 2025
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants