Skip to content

Conversation

@rahulverma012
Copy link
Contributor

added new momentum dependent particle Identification cuts

Added Generator level and truth level analysis in the code
Kaon Isospin workflow was removed  from this file during some other commit. Functionality added again
Added new momentum dependent particle identification cuts
@github-actions github-actions bot added the pwgcf label Mar 11, 2025
@github-actions github-actions bot changed the title Kaon isospin fluctuation particle identification updated [PWGCF] Kaon isospin fluctuation particle identification updated Mar 11, 2025
@rahulverma012
Copy link
Contributor Author

Dear @victor-gonzalez,
I have updated the particle Identification functions in the task. Please review the PR

Best Regards,
Rahul Verma

@rahulverma012
Copy link
Contributor Author

Dear @victor-gonzalez
Regarding one of your comments on use of defining BITSET instead of std::bitset in one of previous PRs. When I checked std::bitset, I had seen its use in printing a number in binary format. Also other contributors have used similar macroname to set bit of a particular variable, there they have directly used the name bitset ( #define bitset() ) that's why i put the comment not to use same name as std::bitset. Also One needs to define variable using of type std::bitset to use .set(iBit) to set the ithBit. I defined the macro to follow same procedure as others.
image

best Regards,
Rahul Verma

@victor-gonzalez
Copy link
Collaborator

Dear @victor-gonzalez Regarding one of your comments on use of defining BITSET instead of std::bitset in one of previous PRs. When I checked std::bitset, I had seen its use in printing a number in binary format. Also other contributors have used similar macroname to set bit of a particular variable, there they have directly used the name bitset ( #define bitset() ) that's why i put the comment not to use same name as std::bitset. Also One needs to define variable using of type std::bitset to use .set(iBit) to set the ithBit. I defined the macro to follow same procedure as others. image

best Regards, Rahul Verma

Well, I guess people write documentation for others to read it
https://cplusplus.com/reference/bitset/bitset/

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) March 11, 2025 21:56
@rahulverma012
Copy link
Contributor Author

Dear @victor-gonzalez
check "build/O2Physics/o2/macOS-arm" failed, but the reason of failure is not coming from my task. It is coming from error in some other files. Can you suggest what to do now?
Best Regards,
Rahul

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) March 14, 2025 18:13
@victor-gonzalez victor-gonzalez merged commit 8c26b35 into AliceO2Group:master Mar 14, 2025
12 checks passed
lubynets pushed a commit to lubynets/O2Physics that referenced this pull request Mar 22, 2025
…ceO2Group#10449)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
…ceO2Group#10449)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
njacazio pushed a commit that referenced this pull request Apr 11, 2025
)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Apr 15, 2025
…ceO2Group#10449)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
…ceO2Group#10449)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
…ceO2Group#10449)

Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants