Skip to content

Conversation

@davkk
Copy link
Contributor

@davkk davkk commented Mar 16, 2025

This PR:

  • fixes segfault when CCDB timestamps configurable array is not empty
  • changes the default values for some of the configurables for convenience
  • updates the binning of Tracks_*_MC/hPt histogram to take values from confTempFitVarpTBins configurable (in FemtoUniverseParticleHisto.h)
  • adds a new EfficiencyCorrection class, that builds on top of the EfficiencyCalculator

The new EfficiencyCorrection class

  • it assumes the necessary weights are already calculated and directly stored in CCDB (instead of simple efficiency histograms)
  • simplifies the flow on the side of the framework (less configurables, no metadata needed for CCDB objects) in preparation for support of histograms of more dimensions
  • EfficiencyCalculator is kept for backward compatibility, however its flow is limited, as it does not include other aspects like secondary contamination
  • requires custom script for calculating the weights and uploading them to the CCDB (upload can easily be done with o2-ccdb-upload script)

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for f30a43d at 2025-03-16 23:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:91:40: error: there are no arguments to 'loadHistFromCCDB' that depend on a template parameter, so a declaration of 'loadHistFromCCDB' must be available [-fpermissive]
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:82:30: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:91:56: error: 'loadHistFromCCDB' was not declared in this scope
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:91:40: error: there are no arguments to 'loadHistFromCCDB' that depend on a template parameter, so a declaration of 'loadHistFromCCDB' must be available [-fpermissive]
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:82:30: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCalculator.h:91:56: error: 'loadHistFromCCDB' was not declared in this scope
/sw/SOURCES/O2Physics/10528-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseEfficiencyCorrection.h:79:30: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@zchochul zchochul merged commit d9a1bb1 into AliceO2Group:master Mar 17, 2025
13 of 15 checks passed
lubynets pushed a commit to lubynets/O2Physics that referenced this pull request Mar 22, 2025
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
njacazio pushed a commit that referenced this pull request Apr 11, 2025
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Apr 15, 2025
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants