Skip to content

[PWGCF] Add PID in MC process functions #10749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
victor-gonzalez merged 17 commits into from
Apr 4, 2025
Merged

[PWGCF] Add PID in MC process functions #10749

victor-gonzalez merged 17 commits into from
Apr 4, 2025

Conversation

@cnkoster
Copy link
Contributor

@cnkoster cnkoster commented Apr 3, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label Apr 3, 2025
@github-actions github-actions bot changed the title Add PID in MC process functions [PWGCF] Add PID in MC process functions Apr 3, 2025
@alibuild alibuild mentioned this pull request Apr 3, 2025
Merged
cnkoster and others added 2 commits April 3, 2025 16:34
@cnkoster
Merge pull request #43 from alibuild/alibot-cleanup-10749
a3b1f68 
[PWGCF] Please consider the following formatting changes to AliceO2Group#10749
@cnkoster
o2-linter fixes
c31a854
@alibuild alibuild mentioned this pull request Apr 3, 2025
Merged
@alibuild alibuild mentioned this pull request Apr 3, 2025
Merged
@alibuild alibuild mentioned this pull request Apr 3, 2025
Merged
@cnkoster cnkoster marked this pull request as ready for review April 3, 2025 18:26
victor-gonzalez
victor-gonzalez previously approved these changes Apr 3, 2025
View reviewed changes
@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented Apr 3, 2025

Does the code compile locally?

@alibuild
Copy link
Collaborator

alibuild commented Apr 3, 2025

Error while checking build/O2Physics/o2 for 39cedd9 at 2025-04-03 20:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1314:2: error: expected '}' at end of input
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:9: error: 'doprocessData' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:26: error: 'doprocessMCReco' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:45: error: 'doprocessMCGen' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:420:9: error: 'doprocessMCGen' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:607:9: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1314:2: error: expected unqualified-id at end of input
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Apr 4, 2025
Merged
@cnkoster
Merge pull request #47 from alibuild/alibot-cleanup-10749
a1b0fe6 
[PWGCF] Please consider the following formatting changes to AliceO2Group#10749
@cnkoster
Copy link
Contributor Author

cnkoster commented Apr 4, 2025

I fixed the problem (there was a "{" somewhere where it shouldn't) and now it builds locally.
However, the build on macOS still seems to fail

@victor-gonzalez victor-gonzalez merged commit e946fff into AliceO2Group:master Apr 4, 2025
12 of 13 checks passed
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
@cnkoster @alibuild @louisemillot
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
d48a630 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio pushed a commit that referenced this pull request Apr 11, 2025
@cnkoster @alibuild @njacazio
[PWGCF] Add PID in MC process functions (#10749)
85d84df 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@cnkoster @alibuild @ariedel-cern
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
1319f6a 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@cnkoster @alibuild @smaff92
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
36e834b 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@cnkoster @alibuild @CesarOmarRA
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
0f75664 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnkoster @victor-gonzalez @alibuild