Skip to content

[PWGLF] initial task for lambda correlation study #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChiaraDeMartin95 merged 15 commits into from
Apr 15, 2025
Merged

[PWGLF] initial task for lambda correlation study #10810

ChiaraDeMartin95 merged 15 commits into from
Apr 15, 2025

Conversation

@prottayCMT
Copy link
Contributor

@prottayCMT prottayCMT commented Apr 10, 2025

No description provided.

@github-actions github-actions bot added the pwglf label Apr 10, 2025
@alibuild
Copy link
Collaborator

alibuild commented Apr 10, 2025

Error while checking build/O2Physics/o2 for 699c75e at 2025-04-10 13:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10810-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdapolspspin.cxx:254:12: error: unused variable 'sinTheta1' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10810-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdapolspspin.cxx:255:12: error: unused variable 'sinTheta2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10810-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdapolspspin.cxx:226:49: error: unused parameter 'candmass' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/10810-slc9_x86-64/0/PWGLF/Tasks/Strangeness/lambdapolspspin.cxx:321:90: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Apr 10, 2025

Hi @prottayCMT , since you are adding a new code file, please address the linter warnings and make sure it does not introduce new issues.

vkucera
vkucera reviewed Apr 10, 2025
View reviewed changes
@prottayalice
Copy link

prottayalice commented Apr 13, 2025

Hi @prottayCMT , since you are adding a new code file, please address the linter warnings and make sure it does not introduce new issues.

Reply: removed most of the o2linter issues now

vkucera
vkucera reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prottayCMT for clearing up the issues. Please see my further suggestions.

vkucera
vkucera reviewed Apr 14, 2025
View reviewed changes
vkucera
vkucera approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prottayCMT for addressing all the issues.

@ChiaraDeMartin95 ChiaraDeMartin95 merged commit 2c30cf3 into AliceO2Group:master Apr 15, 2025
14 of 15 checks passed
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@prottayCMT @ariedel-cern
[PWGLF] initial task for lambda correlation study (AliceO2Group#10810)
868af71 
Co-authored-by: Prottay Das <prottay@alipap1.cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@prottayCMT @smaff92
[PWGLF] initial task for lambda correlation study (AliceO2Group#10810)
99aa211 
Co-authored-by: Prottay Das <prottay@alipap1.cern.ch>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@prottayCMT @CesarOmarRA
[PWGLF] initial task for lambda correlation study (AliceO2Group#10810)
01f16bf 
Co-authored-by: Prottay Das <prottay@alipap1.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@ChiaraDeMartin95 ChiaraDeMartin95 ChiaraDeMartin95 approved these changes

@skundu692 skundu692 skundu692 approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@njacazio njacazio Awaiting requested review from njacazio

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

+1 more reviewer

@prottayalice prottayalice prottayalice left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@prottayCMT @alibuild @vkucera @prottayalice @ChiaraDeMartin95 @skundu692