Skip to content

[PWGHF] Added centrality to D+ tree tables #10895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Marcellocosti wants to merge 8 commits into from
Closed

[PWGHF] Added centrality to D+ tree tables #10895

Marcellocosti wants to merge 8 commits into from

Conversation

@Marcellocosti
Copy link
Contributor

@Marcellocosti Marcellocosti commented Apr 17, 2025

Updating PR #10876 with correct process function activation.

@github-actions github-actions bot added the pwghf PWG-HF label Apr 17, 2025
@alibuild alibuild mentioned this pull request Apr 17, 2025
Merged
@Marcellocosti
Merge pull request #11 from alibuild/alibot-cleanup-10895
424a99e 
[PWGHF] Please consider the following formatting changes to AliceO2Group#10895
@vkucera
Copy link
Collaborator

vkucera commented Apr 17, 2025

Why don't you update #10876 ?

@vkucera vkucera marked this pull request as draft April 17, 2025 13:48
@Marcellocosti
Copy link
Contributor Author

Marcellocosti commented Apr 17, 2025

Hi @vkucera, the issue is that I introduced a further modification in #10876 after merging the PR related to the formatting changes. Then I force-pushed the modification, and but the PR couldn't be updated.

@vkucera
Copy link
Collaborator

vkucera commented Apr 17, 2025

Hi @vkucera, the issue is that I introduced a further modification in #10876 after merging the PR related to the formatting changes. Then I force-pushed the modification, and but the PR couldn't be updated.

As far as I can see, you did not force-push the modification. Even if you did, I don't see why opening a new PR would solve any conflicts. A PR can always be updated unless merged or closed. Please do not create duplicate PRs to solve Git issues. Also consider using pre-commit for automatic formatting at the time of making your commits.

@vkucera vkucera closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel will be requested when the pull request is marked ready for review gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano will be requested when the pull request is marked ready for review stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marcellocosti @vkucera @alibuild