Skip to content

Conversation

@mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Apr 25, 2025

Continuation of #7805

@github-actions github-actions bot added the pwghf PWG-HF label Apr 25, 2025
@github-actions
Copy link

github-actions bot commented Apr 25, 2025

O2 linter results: ❌ 24 errors, ⚠️ 0 warnings, 🔕 4 disabled

@github-actions github-actions bot changed the title [PWGHF]: store PID info in 3-prong candidate table and propagate it to analyses. [PWGHF] store PID info in 3-prong candidate table and propagate it to analyses. Apr 25, 2025
@mfaggin mfaggin force-pushed the pidCandCr3Prong branch 2 times, most recently from 1d634d1 to 5a5fa5e Compare April 25, 2025 12:56
@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 25, 2025

@fgrosa I should have addressed everything for Lc. Other 3 prongs have to be adapted.

mfaggin added a commit to mfaggin/O2Physics that referenced this pull request Apr 28, 2025
Please consider the following formatting changes to AliceO2Group#10984
mfaggin added a commit to mfaggin/O2Physics that referenced this pull request Apr 28, 2025
Please consider the following formatting changes to AliceO2Group#10984
@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 28, 2025

@fgrosa Lc, D+ and Ds should be fine.

@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 29, 2025

Also D* should be fine.

@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 30, 2025

@fgrosa now also Xic->pKpi is in place. If you agree, I open it for review

mfaggin added a commit to mfaggin/O2Physics that referenced this pull request Apr 30, 2025
Please consider the following formatting changes to AliceO2Group#10984
@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 30, 2025

Hi @mfaggin, thanks a lot! There are still a few files to be modified:

thanks a lot @fgrosa, by mistake I overlooked the change of getInputFeatures for the Ds and Xic, my bad. This should be fine now.

Instead, for the resonance candidate creator I do not understand what I shall change. In fact, I only see the explicit query of PID information for the bachelor track/V0, and not for the daughters of 2-prong, 3-prong, or D* candidates. What am I missing?

@fgrosa
Copy link
Collaborator

fgrosa commented Apr 30, 2025

Hi @mfaggin, thanks a lot! There are still a few files to be modified:

thanks a lot @fgrosa, by mistake I overlooked the change of getInputFeatures for the Ds and Xic, my bad. This should be fine now.

Instead, for the resonance candidate creator I do not understand what I shall change. In fact, I only see the explicit query of PID information for the bachelor track/V0, and not for the daughters of 2-prong, 3-prong, or D* candidates. What am I missing?

Hi @mfaggin, you are indeed right!
I recalled that we were adding the PID of the daughter particles also for the reso builders (because the data model is essentially in common with the B hadrons), but that's not the case indeed. No need to modify the dataCreatorCharmResoReduced.cxx

@mfaggin
Copy link
Collaborator Author

mfaggin commented Apr 30, 2025

Hi @mfaggin, thanks a lot! There are still a few files to be modified:

thanks a lot @fgrosa, by mistake I overlooked the change of getInputFeatures for the Ds and Xic, my bad. This should be fine now.
Instead, for the resonance candidate creator I do not understand what I shall change. In fact, I only see the explicit query of PID information for the bachelor track/V0, and not for the daughters of 2-prong, 3-prong, or D* candidates. What am I missing?

Hi @mfaggin, you are indeed right! I recalled that we were adding the PID of the daughter particles also for the reso builders (because the data model is essentially in common with the B hadrons), but that's not the case indeed. No need to modify the dataCreatorCharmResoReduced.cxx

thanks for the confirmation @fgrosa . Then, in principle there should be everything.

@mfaggin mfaggin marked this pull request as ready for review April 30, 2025 14:54
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

@mfaggin mfaggin enabled auto-merge (squash) May 2, 2025 16:50
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@mfaggin mfaggin merged commit 9c07344 into AliceO2Group:master May 2, 2025
15 of 17 checks passed
bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@mfaggin mfaggin deleted the pidCandCr3Prong branch May 5, 2025 08:59
lubynets added a commit to lubynets/O2Physics that referenced this pull request May 5, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
… analyses. (AliceO2Group#10984)

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants