[PWGEM/PhotonMeson] Bug fixes for BC wise pi0 task #11030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nstrangm
commented
Apr 29, 2025
nstrangm
commented
- Filters in emcalBcWisePi0.cxx now correctly use the configurable values and not just the defaults -> changed a few data types from unsigned to signed int to allow for filter comparison
- z vertex position now correctly read as int16 (instead of int8)
- Added MC pi0 min pT configurable to reduce derived data size
- Added check for mc particle ID in map before calling its value (map does not contain all pi0s, as not all pi0s are stored)
nstrangm
requested review from
alibuild,
dsekihat,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 18 errors, |
mfaggin
pushed a commit
to mfaggin/O2Physics
that referenced
this pull request
Apr 30, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
bghanley1995
pushed a commit
to bghanley1995/O2Physics
that referenced
this pull request
May 5, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
May 17, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.