Skip to content

[ALICE3] Update OTF RICH PID #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 7 commits into from
May 2, 2025
Merged

[ALICE3] Update OTF RICH PID #11041

njacazio merged 7 commits into from
May 2, 2025

Conversation

@NNicassio99
Copy link
Contributor

@NNicassio99 NNicassio99 commented Apr 30, 2025

Solved issues with original onTheFlyRICHPID.cxx task.
Now updates should be done correctly according to .json input.
Added a new function for analytic calculation of ring angular resolution sector-by-sector.
Included the possibility to have different aerogel refractive index for the different modules.

@github-actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

O2 linter results: ❌ 141 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title up_to_date_OTF_RICH_PID [ALICE3] up_to_date_OTF_RICH_PID Apr 30, 2025
@alibuild alibuild mentioned this pull request Apr 30, 2025
Closed
@alibuild alibuild mentioned this pull request Apr 30, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Apr 30, 2025

Error while checking build/O2Physics/o2 for e168be7 at 2025-04-30 19:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:319:41: error: unused parameter 'initContext' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:598:11: error: unused variable 'R_sec_tof' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:599:11: error: unused variable 'z_sec_tof' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Apr 30, 2025

Error while checking build/O2Physics/o2 for bd956cb at 2025-04-30 19:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:318:41: error: unused parameter 'initContext' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:597:11: error: unused variable 'R_sec_tof' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:598:11: error: unused variable 'z_sec_tof' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 1, 2025

Error while checking build/O2Physics/o2 for 7a2a0c5 at 2025-05-01 12:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:318:41: error: unused parameter 'initContext' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:597:11: error: unused variable 'R_sec_tof' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:598:11: error: unused variable 'z_sec_tof' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 2, 2025

Error while checking build/O2Physics/o2 for df20819 at 2025-05-02 07:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:597:11: error: unused variable 'R_sec_tof' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11041-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyRICHPID.cxx:598:11: error: unused variable 'z_sec_tof' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio changed the title [ALICE3] up_to_date_OTF_RICH_PID [ALICE3] Update OTF RICH PID May 2, 2025
@njacazio njacazio enabled auto-merge (squash) May 2, 2025 05:48
@njacazio njacazio merged commit 18007cd into AliceO2Group:master May 2, 2025
13 of 16 checks passed
bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025
@NNicassio99 @njacazio @bghanley1995
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
f0ae609 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@NNicassio99 @njacazio @jinhyunni
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
e0d3fa9 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@NNicassio99 @njacazio @jinhyunni
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
88cb9c1 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@NNicassio99 @njacazio
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
bd8fc65 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@NNicassio99 @njacazio @ariedel-cern
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
112dcd3 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@NNicassio99 @njacazio
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
b381cb3 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@NNicassio99 @njacazio @smaff92
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
7e56254 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@NNicassio99 @njacazio @CesarOmarRA
[ALICE3] Update OTF RICH PID (AliceO2Group#11041)
1f5ffe9 
- Parameter updates should be done correctly according to .json input.
- Added a new function for analytic calculation of ring angular resolution sector-by-sector.
- Included the possibility to have different aerogel refractive index for the different modules.

Co-authored-by: Nicola Nicassio <nicolanicassio@eduroam-174231724-1.dyndns.cern.ch>
Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NNicassio99 @alibuild @njacazio