[PWGLF] remove DCAfitter and fixed O2linter error #11048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacwovie
requested review from
alibuild,
chiarapinto,
fmazzasc,
maciacco,
njacazio and
skundu692
as code owners
|
O2 linter results: ❌ 4 errors, |
github-actions
bot
changed the title
[PWGLF] Please consider the following formatting changes to AliceO2Group#11048
fmazzasc
requested changes
May 2, 2025
| HistogramRegistry m_qaRegistry{ | ||
| SameKindPair<CollisionsFull, TrackCandidates, BinningType> mPair{binningPolicy, settingNoMixedEvents, -1, &cache}; | ||
|
|
||
| std::array<float, 6> mBBparamsDe; |
Collaborator
There was a problem hiding this comment.
Why do you call it mBBparamsDe ? Shouldn't this be mBBparamsHe as it was at the begninning?
Contributor
Author
There was a problem hiding this comment.
Sorry for the mistake. I'm working on pi-d femto workflow so I must have confused the two.
Contributor
Author
There was a problem hiding this comment.
I changed it back. It's mBBparamsHe now :)
fmazzasc
approved these changes
May 4, 2025
bghanley1995
pushed a commit
to bghanley1995/O2Physics
that referenced
this pull request
May 5, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
May 11, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
May 17, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Li4 dose not have pdg code in PDG_t and constants::physics::Pdg so I just leave it there