[ALICE3] A3TOF: fix linter #11056

njacazio · 2025-05-02T17:09:34Z

No description provided.

github-actions · 2025-05-02T17:09:49Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild

Auto-approving on behalf of @njacazio.

alibuild · 2025-05-02T19:02:58Z

Error while checking build/O2Physics/o2 for 0f72faf at 2025-05-02 21:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:209:55: error: no matching function for call to 'o2::framework::HistogramRegistry::add<TH2>(std::string&, std::string&, o2::framework::HistType, <brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:590:32: error: 'kParticlex' was not declared in this scope; did you mean 'kParticles'?
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:590:42: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:611:23: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:612:23: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:649:27: error: 'kPion' was not declared in this scope; did you mean 'kIdPion'?
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:662:25: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:664:25: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:674:73: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:680:73: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:698:32: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:698:51: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:698:70: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:698:89: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:698:108: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:700:32: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:700:51: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:700:70: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:700:89: error: invalid types 'int[int]' for array subscript
/sw/SOURCES/O2Physics/11056-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:700:108: error: invalid types 'int[int]' for array subscript
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2025-05-02T19:23:23Z

Error while checking build/O2Physics/o2 for df618ed at 2025-05-02 21:23:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
/sw/slc9_x86-64/O2/daily-20250502-0000-local1/include/Framework/StructToTuple.h:331:11: error: 21 names provided for structured binding
ninja: build stopped: subcommand failed.

Full log here.

alibuild

Auto-approving on behalf of @njacazio.

vkucera · 2025-05-04T13:48:35Z

Thanks @njacazio

A3TOF: fix linter

b64ab55

njacazio requested review from alibuild and hscheid as code owners May 2, 2025 17:09

github-actions bot added the alice3 label May 2, 2025

github-actions bot changed the title ~~A3TOF: fix linter~~ [ALICE3] A3TOF: fix linter May 2, 2025

alibuild mentioned this pull request May 2, 2025

Please consider the following formatting changes to #11056 #11057

Merged

njacazio and others added 2 commits May 2, 2025 19:14

Update onTheFlyTOFPID.cxx

9dfc231

Please consider the following formatting changes to #11056 (#11057)

35c31a8

alibuild mentioned this pull request May 2, 2025

Please consider the following formatting changes to #11056 #11058

Merged

alibuild and others added 5 commits May 2, 2025 19:15

Please consider the following formatting changes to #11056 (#11058)

f098fee

Update

6246437

Update

dd3c3bf

Update

c3af594

Update

c8a3c2a

alibuild mentioned this pull request May 2, 2025

Please consider the following formatting changes to #11056 #11059

Merged

alibuild and others added 4 commits May 2, 2025 19:33

Please consider the following formatting changes to #11056 (#11059)

abd22ee

Update

4445fb9

Update onTheFlyTOFPID.cxx

64fcb4a

Update

0f72faf

njacazio enabled auto-merge (squash) May 2, 2025 17:57

alibuild previously approved these changes May 2, 2025

View reviewed changes

Update

92cdf2e

njacazio dismissed alibuild’s stale review via 92cdf2e May 2, 2025 18:55

Update

df618ed

Update

91ed52e

alibuild mentioned this pull request May 2, 2025

Please consider the following formatting changes to #11056 #11061

Merged

Please consider the following formatting changes to #11056 (#11061)

4dc921d

U

46bb11f

alibuild mentioned this pull request May 2, 2025

Please consider the following formatting changes to #11056 #11062

Merged

Please consider the following formatting changes to #11056 (#11062)

e7803db

njacazio disabled auto-merge May 2, 2025 19:59

njacazio enabled auto-merge (squash) May 2, 2025 19:59

alibuild approved these changes May 2, 2025

View reviewed changes

njacazio merged commit dd19ed8 into master May 2, 2025
12 of 15 checks passed

njacazio deleted the njacazio-patch-1 branch May 2, 2025 20:43

bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

c176027

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

9eca14a

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

4119298

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

3e2a7b2

ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

5b5308b

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

94ecc51

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

b9a22f0

alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025

[ALICE3] A3TOF: fix linter (AliceO2Group#11056)

d91b22f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ALICE3] A3TOF: fix linter #11056

[ALICE3] A3TOF: fix linter #11056

Uh oh!

njacazio commented May 2, 2025

Uh oh!

github-actions bot commented May 2, 2025 •

edited

Loading

Uh oh!

alibuild left a comment

Uh oh!

alibuild commented May 2, 2025

Uh oh!

alibuild commented May 2, 2025

Uh oh!

alibuild left a comment

Uh oh!

Uh oh!

vkucera commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

[ALICE3] A3TOF: fix linter #11056

[ALICE3] A3TOF: fix linter #11056

Uh oh!

Conversation

njacazio commented May 2, 2025

Uh oh!

github-actions bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented May 2, 2025

Uh oh!

alibuild commented May 2, 2025

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vkucera commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions bot commented May 2, 2025 •

edited

Loading