-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGHF] Fix data type for D+ and Ds tables. #11162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 11 errors, |
|
Hi @mfaggin, Thanks for the commit! all good to me |
|
hi @zhangbiao-phy I see that you removed your comment. Indeed I should have preserved the correct data type with proton PID included for the Lc |
|
Error while checking build/O2Physics/o2 for 6975ff3 at 2025-05-12 20:40: Full log here. |
|
@fgrosa @zhangbiao-phy let me know if you like the solution that I propose in my last commit for the reduced data creator task. I think this is the only way to be compatible with the development done in the PR #11141 . |
The better way would of course be to split the reduced PID tables per species per prong as was done for the main data model. |
Hi @mfaggin, Thanks a lot! It looks good to me! Hi @vkucera, for 3 prong, it's only special for Lb, which requires proton pid. Then for the 2 prong, it is already there in O2Physics/PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx Lines 1190 to 1191 in 415f3ad
|
Thanks @vkucera , I'd leave it to the analysers using the task |
|
Error while checking build/O2Physics/o2 for 415f3ad at 2025-05-13 10:41: Full log here. |
|
hi @mfaggin, Thanks for the updates! All good to me! |
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Necessary modifications due to #11141