[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

zhangbiao-phy · 2025-05-14T11:37:11Z

For convenience in doing the mixed event locally, I added the collision index to the table

Separate into 3 tables: charm, track, and collision
Add eta and phi into the table --> calculate k*, kT, mT locally
Remove table filling in the mix-event function (if the test is smooth, this part will be deleted later)

github-actions · 2025-05-14T11:37:28Z

O2 linter results: ❌ 57 errors, ⚠️ 0 warnings, 🔕 0 disabled

[PWGHF] Please consider the following formatting changes to AliceO2Group#11191

alibuild · 2025-05-15T17:43:14Z

Error while checking build/O2Physics/o2 for 902f26d at 2025-05-15 19:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/11191-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx:369:15: error: variable 'chargeTrack' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez · 2025-05-15T18:03:27Z

PWGCF/DataModel/FemtoDerived.h

                  fdhf::OriginMcRec);

-DECLARE_SOA_TABLE(FDResultsHFTrkInfo, "AOD", "FDRESULTSHFTRKINFO", //! table to store results for HF femtoscopy
+DECLARE_SOA_TABLE(FDResultsTrk, "AOD", "FDRESULTSTRK", //! table to store results for HF femtoscopy


Please, keep HF as before in the table declaration

victor-gonzalez · 2025-05-15T18:04:19Z

PWGCF/DataModel/FemtoDerived.h

                  femtodreamparticle::TPCNSigmaPr,
                  femtodreamparticle::TOFNSigmaPr);

+DECLARE_SOA_TABLE(FDResultsColl, "AOD", "FDRESULTSCOLL", //! table to store results for HF femtoscopy


Please, incorporate HF in the table declaration

PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx

alibuild

Auto-approving on behalf of @zhangbiao-phy.

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

zhangbiao-phy added 2 commits May 14, 2025 13:33

Update FemtoDerived.h

2b20afc

Update taskCharmHadronsFemtoDream.cxx

7a1e24c

github-actions bot added pwghf PWG-HF pwgcf datamodel labels May 14, 2025

github-actions bot changed the title ~~[PWGHF, PWGCF] add the collision index into the table~~ [PWGHF,PWGCF] add the collision index into the table May 14, 2025

Update FemtoDerived.h

1bae271

zhangbiao-phy marked this pull request as ready for review May 14, 2025 15:46

zhangbiao-phy requested review from NicoleBastid, alibuild, apalasciano, ariedel-cern, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, jgrosseo, jpxrk, lauraser, lgraczykCern, mfaggin, mmazzilli, otonvd, prchakra, saganatt, victor-gonzalez, vkucera and zchochul as code owners May 14, 2025 15:46

alibuild mentioned this pull request May 15, 2025

[PWGHF] Please consider the following formatting changes to #11191 zhangbiao-phy/O2Physics#37

Merged

zhangbiao-phy and others added 3 commits May 15, 2025 17:59

Update FemtoDerived.h

6a5caae

Please consider the following formatting changes

bb6aa93

Merge pull request #37 from alibuild/alibot-cleanup-11191

74ca25c

[PWGHF] Please consider the following formatting changes to AliceO2Group#11191

zhangbiao-phy changed the title ~~[PWGHF,PWGCF] add the collision index into the table~~ [PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task May 15, 2025

remove useless code

49a243c

alibuild mentioned this pull request May 15, 2025

[PWGHF] Please consider the following formatting changes to #11191 zhangbiao-phy/O2Physics#38

Merged

zhangbiao-phy and others added 3 commits May 15, 2025 18:33

Update FemtoDerived.h

2d98b88

Please consider the following formatting changes

b90b527

Merge pull request #38 from alibuild/alibot-cleanup-11191

902f26d

[PWGHF] Please consider the following formatting changes to AliceO2Group#11191

zhangbiao-phy marked this pull request as ready for review May 15, 2025 16:43

remove useless code

f15abf0

victor-gonzalez requested changes May 15, 2025

View reviewed changes

zhangbiao-phy added 2 commits May 15, 2025 20:10

Update FemtoDerived.h

e046fe5

Update taskCharmHadronsFemtoDream.cxx

bd9e762

vkucera reviewed May 15, 2025

View reviewed changes

PWGHF/HFC/Tasks/taskCharmHadronsFemtoDream.cxx Outdated Show resolved Hide resolved

zhangbiao-phy added 2 commits May 15, 2025 21:14

fix name

787aa76

remove useless code

74fe8a3

victor-gonzalez approved these changes May 15, 2025

View reviewed changes

zhangbiao-phy enabled auto-merge (squash) May 16, 2025 07:56

alibuild approved these changes May 16, 2025

View reviewed changes

zhangbiao-phy merged commit 7d40bc8 into AliceO2Group:master May 16, 2025
12 of 13 checks passed

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

73c69a8

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

2ed2e6d

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

3295838

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

33fce90

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

ed020a4

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

e1e985d

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025

[PWGHF,PWGCF] Split same-event table and add the collision infos into…

d8cea14

… lcp femto task (AliceO2Group#11191) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

Uh oh!

zhangbiao-phy commented May 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 14, 2025 •

edited

Loading

Uh oh!

alibuild commented May 15, 2025

Uh oh!

victor-gonzalez May 15, 2025

Uh oh!

zhangbiao-phy May 15, 2025

Uh oh!

victor-gonzalez May 15, 2025

Uh oh!

zhangbiao-phy May 15, 2025

Uh oh!

Uh oh!

alibuild left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

[PWGHF,PWGCF] Split same-event table and add the collision infos into lcp femto task #11191

Uh oh!

Conversation

zhangbiao-phy commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented May 15, 2025

Uh oh!

victor-gonzalez May 15, 2025

Choose a reason for hiding this comment

Uh oh!

zhangbiao-phy May 15, 2025

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez May 15, 2025

Choose a reason for hiding this comment

Uh oh!

zhangbiao-phy May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

zhangbiao-phy commented May 14, 2025 •

edited

Loading

github-actions bot commented May 14, 2025 •

edited

Loading