Skip to content

[ALICE3] Move common track handling to header #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 7 commits into from
May 21, 2025
Merged

[ALICE3] Move common track handling to header #11276

njacazio merged 7 commits into from
May 21, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented May 21, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

O2 linter results: ❌ 239 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update CMakeLists.txt [ALICE3] Update CMakeLists.txt May 21, 2025
@njacazio njacazio changed the title [ALICE3] Update CMakeLists.txt [ALICE3] Move common track handling to header May 21, 2025
@njacazio njacazio marked this pull request as ready for review May 21, 2025 07:58
@njacazio njacazio requested review from alibuild and hscheid as code owners May 21, 2025 07:58
@alibuild
Copy link
Collaborator

alibuild commented May 21, 2025

Error while checking build/O2Physics/o2 for ffc284f at 2025-05-21 10:10:

## sw/BUILD/O2Physics-latest/log
input_line_9:171:43: error: no member named 'framework' in namespace 'o2'
input_line_9:171:66: error: no member named 'framework' in namespace 'o2'
input_line_9:198:61: error: no member named 'framework' in namespace 'o2'
input_line_9:198:84: error: no member named 'framework' in namespace 'o2'
input_line_9:200:3: error: unknown type name 'TrackParCov'
Error: /sw/slc9_x86-64/ROOT/v6-32-06-alice7-5/bin/rootcling: compilation failure (/sw/BUILD/5eca988ddd7cbccbb8d486e40fc63236d384a42a/O2Physics/ALICE3/Core/G__O2PhysicsALICE3Coredb54882d67_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio enabled auto-merge (squash) May 21, 2025 08:20
@alibuild
Copy link
Collaborator

alibuild commented May 21, 2025

Error while checking build/O2Physics/o2 for c4e2827 at 2025-05-21 10:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/Core/TrackUtilities.h:66:36: error: could not convert 'o2::upgrade::convertMCParticleToO2Track<const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<3313470560>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > > >((* & particle), o2track, (* & pdg))' from 'void' to 'o2::track::TrackParCov' {aka 'o2::track::TrackParametrizationWithError<float>'}
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:239:28: error: redeclaration of 'std::vector<OnTheFlyTracker::TrackAlice3> OnTheFlyTracker::tracksAlice3'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:502:18: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'clear'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:662:26: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'push_back'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:692:66: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:693:66: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:694:66: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:845:74: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:847:28: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'push_back'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:906:22: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'push_back'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:926:35: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:927:45: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:928:44: error: no match for 'operator[]' (operand types are 'o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' and 'unsigned int')
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:964:57: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:968:85: error: 'struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:985:36: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:985:36: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20250521-0000-local1/include/DetectorsVertexing/PVertexer.h:285:23: error: 'const struct o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' has no member named 'size'
/sw/slc9_x86-64/O2/daily-20250521-0000-local1/include/DetectorsVertexing/PVertexer.h:290:18: error: no match for 'operator[]' (operand types are 'const o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' and 'int')
/sw/slc9_x86-64/O2/daily-20250521-0000-local1/include/DetectorsVertexing/PVertexer.h:290:53: error: no match for 'operator[]' (operand types are 'const o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' and 'int')
/sw/slc9_x86-64/O2/daily-20250521-0000-local1/include/DetectorsVertexing/PVertexer.h:299:40: error: no match for 'operator[]' (operand types are 'const o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' and 'int')
/sw/slc9_x86-64/O2/daily-20250521-0000-local1/include/DetectorsVertexing/PVertexer.h:305:53: error: no match for 'operator[]' (operand types are 'const o2::framework::Produces<o2::soa::Table<o2::aod::Hash<3658455259>, o2::aod::Hash<2694440362>, o2::aod::Hash<2286545062> > >' and 'int')
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/Core/TrackUtilities.h:66:36: error: could not convert 'o2::upgrade::convertMCParticleToO2Track<o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<3313470560>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > > >((* & particle), o2track, (* & pdg))' from 'void' to 'o2::track::TrackParCov' {aka 'o2::track::TrackParametrizationWithError<float>'}
ninja: build stopped: subcommand failed.

Full log here.

alibuild
alibuild previously approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Collaborator

alibuild commented May 21, 2025

Error while checking build/O2Physics/o2 for 07dff86 at 2025-05-21 13:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/Core/TrackUtilities.h:66:36: error: could not convert 'o2::upgrade::convertMCParticleToO2Track<const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<3313470560>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > > >((* & particle), o2track, (* & pdg))' from 'void' to 'o2::track::TrackParCov' {aka 'o2::track::TrackParametrizationWithError<float>'}
/sw/SOURCES/O2Physics/11276-slc9_x86-64/0/ALICE3/Core/TrackUtilities.h:66:36: error: could not convert 'o2::upgrade::convertMCParticleToO2Track<o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<3313470560>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > > >((* & particle), o2track, (* & pdg))' from 'void' to 'o2::track::TrackParCov' {aka 'o2::track::TrackParametrizationWithError<float>'}
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge May 21, 2025 13:04
@njacazio njacazio enabled auto-merge (squash) May 21, 2025 13:04
alibuild
alibuild approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 6756192 into master May 21, 2025
11 of 14 checks passed
@njacazio njacazio deleted the njacazio-patch-1 branch May 21, 2025 13:49
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@njacazio @ariedel-cern
[ALICE3] Move common track handling to header (AliceO2Group#11276)
b9190ac
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@njacazio @jinhyunni
[ALICE3] Move common track handling to header (AliceO2Group#11276)
2825a88
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@njacazio
[ALICE3] Move common track handling to header (AliceO2Group#11276)
35c7d8a
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@njacazio
[ALICE3] Move common track handling to header (AliceO2Group#11276)
93b8ecb
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@njacazio @smaff92
[ALICE3] Move common track handling to header (AliceO2Group#11276)
d0d54c1
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@njacazio @CesarOmarRA
[ALICE3] Move common track handling to header (AliceO2Group#11276)
d3ce244
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@njacazio @jloemker
[ALICE3] Move common track handling to header (AliceO2Group#11276)
809f98f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild