Skip to content

[Common] Fix PID response for Z=2 nuclei #11795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fmazzasc merged 2 commits into from
Jul 4, 2025
Merged

[Common] Fix PID response for Z=2 nuclei #11795

fmazzasc merged 2 commits into from
Jul 4, 2025

Conversation

@fmazzasc
Copy link
Collaborator

@fmazzasc fmazzasc commented Jun 27, 2025

No description provided.

@fmazzasc fmazzasc requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners June 27, 2025 06:13
@github-actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

O2 linter results: ❌ 18 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Fix PID response for Z=2 nuclei [Common] Fix PID response for Z=2 nuclei Jun 27, 2025
@alibuild
Copy link
Collaborator

alibuild commented Jun 27, 2025

Error while checking build/O2Physics/o2 for 6e27d71 at 2025-06-27 08:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11795-slc9_x86-64/0/Common/DataModel/PIDResponseITS.h:96:18: error: unused variable 'charge' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@fmazzasc
Copy link
Collaborator Author

fmazzasc commented Jul 1, 2025

@ddobrigk , could you merge this pr? thank you!

@fmazzasc fmazzasc enabled auto-merge (squash) July 1, 2025 08:26
@fmazzasc fmazzasc merged commit 3271038 into master Jul 4, 2025
12 of 14 checks passed
@fmazzasc fmazzasc deleted the fmazzasc-patch-1 branch July 4, 2025 08:01
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@fmazzasc @jpxrk
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
230c8b4
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@fmazzasc
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
0343bcb
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@fmazzasc
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
d2ccb35
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@fmazzasc @vojmach
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
2b591d5
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@fmazzasc @jloemker
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
cb82e90
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@fmazzasc
[Common] Fix PID response for Z=2 nuclei (AliceO2Group#11795)
e016add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common datamodel

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmazzasc @alibuild @ddobrigk