Skip to content

Conversation

@rebeccacerri
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

O2 linter results: ❌ 34 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Creating Task Tag-And-Probe matching efficiency studies [PWGDQ] Creating Task Tag-And-Probe matching efficiency studies Jul 1, 2025
@alibuild
Copy link
Collaborator

alibuild commented Jul 1, 2025

Error while checking build/O2Physics/o2 for ef3ad66 at 2025-07-02 00:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11866-slc9_x86-64/0/PWGDQ/Tasks/TagAndProbe.cxx:376:14: error: unused variable 'twoTrackFilter' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Collaborator

@mcoquet642 mcoquet642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Rebecca, I see that in this code there are many parts which do not seem to be actually used, e.g. the various columns in the dqanalysisflags, the different "using" types for events and barrel, and the defined histograms. Could you elaborate why this is needed ? More generally, is it not possible to add these T&P histograms directly in the tableReader with minimal changes ?

@rebeccacerri
Copy link
Contributor Author

rebeccacerri commented Jul 2, 2025

Dear Maurice, thank you for your comments. This is the first draft of the code for the Tag and Probe matching efficiency (SW task). Together with Luca, we thought it would be useful to have a separate task from the table reader, allowing for an independent analysis without relying on the table reader, which makes use of many processes and could lead to a memory consumption very easily. The idea would be to potentially extend this task to the central barrel as well.
It works locally, but we are currently limited by the statistics we can analyse. Therefore, we have opened this pull request hoping we could start to test this task on Hyperloop.

@mcoquet642
Copy link
Collaborator

@rebeccacerri thanks for the explanation. In that case, on my side I would be in favor of having this first version as light as possible and removing the unused stuff, that could be added later on when a given implementation requires it (in particular the type definitions and the flags)

@rebeccacerri
Copy link
Contributor Author

Dear Maurice, thank you for your comment. I have uploaded a minimal version with the unused parts removed. Let me know what you think about it. Thank you once again

@mcoquet642 mcoquet642 merged commit 6425ae5 into AliceO2Group:master Jul 6, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants