-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGDQ] Creating Task Tag-And-Probe matching efficiency studies #11866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWGDQ] Creating Task Tag-And-Probe matching efficiency studies #11866
Conversation
|
O2 linter results: ❌ 34 errors, |
|
Error while checking build/O2Physics/o2 for ef3ad66 at 2025-07-02 00:00: Full log here. |
mcoquet642
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Rebecca, I see that in this code there are many parts which do not seem to be actually used, e.g. the various columns in the dqanalysisflags, the different "using" types for events and barrel, and the defined histograms. Could you elaborate why this is needed ? More generally, is it not possible to add these T&P histograms directly in the tableReader with minimal changes ?
|
Dear Maurice, thank you for your comments. This is the first draft of the code for the Tag and Probe matching efficiency (SW task). Together with Luca, we thought it would be useful to have a separate task from the table reader, allowing for an independent analysis without relying on the table reader, which makes use of many processes and could lead to a memory consumption very easily. The idea would be to potentially extend this task to the central barrel as well. |
|
@rebeccacerri thanks for the explanation. In that case, on my side I would be in favor of having this first version as light as possible and removing the unused stuff, that could be added later on when a given implementation requires it (in particular the type definitions and the flags) |
|
Dear Maurice, thank you for your comment. I have uploaded a minimal version with the unused parts removed. Let me know what you think about it. Thank you once again |
No description provided.