Skip to content

[PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis #12758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 36 commits into from
Oct 21, 2025
Merged

[PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis #12758

zhangbiao-phy merged 36 commits into from
Oct 21, 2025

Conversation

@Tao-Fang
Copy link
Contributor

@Tao-Fang Tao-Fang commented Aug 27, 2025

1, XicotoXiPi ML was added to taskXic0ToXipi and CandidateSelectiontable
2, Add some geometric variable was in treeCreator

@github-actions github-actions bot changed the title Add ML to XicotoXiPi DCA Filter analysis [PWGHF] Add ML to XicotoXiPi DCA Filter analysis Aug 27, 2025
@github-actions
Copy link

github-actions bot commented Aug 27, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 4 disabled

@alibuild alibuild mentioned this pull request Aug 27, 2025
Merged
@Tao-Fang Tao-Fang marked this pull request as ready for review August 27, 2025 09:10
@alibuild
Copy link
Collaborator

alibuild commented Aug 27, 2025

Error while checking build/O2Physics/o2 for eff8922 at 2025-08-27 11:27:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorToXiPi.cxx:17:10: fatal error: PWGHF/Core/HfMlResponseXic0ToXiPi.h: No such file or directory
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:57:17: error: 'HfMlLcToK0sP' is not a member of 'o2::aod'; did you mean 'HfSelLcToK0sP'?
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:57:29: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:276:32: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:284:32: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:291:30: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:319:32: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:327:32: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/12758-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorLcToK0sP.cxx:334:30: error: expression cannot be used as a function
ninja: build stopped: subcommand failed.

Full log here.

@Tao-Fang Tao-Fang marked this pull request as draft August 27, 2025 09:31
vkucera
vkucera reviewed Oct 8, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 8, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 8, 2025
View reviewed changes
PWGHF/TableProducer/candidateSelectorToXiPi.cxx

bool resultSelections = true; // True if the candidate passes all the selections, False otherwise

auto ptCand = RecoDecay::pt(candidate.pxCharmBaryon(), candidate.pyCharmBaryon());
Copy link
Collaborator

@vkucera vkucera Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the candidate pt not returned simply by candidate.pt()?

Copy link
Contributor Author

@Tao-Fang Tao-Fang Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PtCharmBaryon was not creatted at this PR, if simply by candidate.pt() there will come some erros, of course It can be added in a later PR.

@Tao-Fang Tao-Fang marked this pull request as draft October 8, 2025 13:03
@alibuild alibuild mentioned this pull request Oct 11, 2025
Merged
@Tao-Fang
Copy link
Contributor Author

Tao-Fang commented Oct 11, 2025

Hi @Tao-Fang , thanks! Can you be more specific about how you did the local test, please?
I have used these commands, previous oversight was entering PWGHF/TableProducer instead of PWGHF.
"cd /home/linux/alice/sw/BUILD/O2Physics-latest/O2Physics/
alienv enter O2Physics/latest ninja/latest
ninja PWGHF/install"

@Tao-Fang Tao-Fang marked this pull request as ready for review October 11, 2025 11:29
@vkucera
Copy link
Collaborator

vkucera commented Oct 11, 2025 •
edited
Loading

Hi @Tao-Fang , thanks! Can you be more specific about how you did the local test, please?
I have used these commands, previous oversight was entering PWGHF/TableProducer instead of PWGHF.
"cd /home/linux/alice/sw/BUILD/O2Physics-latest/O2Physics/
alienv enter O2Physics/latest ninja/latest
ninja PWGHF/install"

Hi @Tao-Fang , first of all, these are wrong steps to recompile O2Physics. Where did you see them? Please follow the latest official instructions.
Second, this is just compilation. What about the rest of testing (checking for compilation warnings, running, validating the output)?
Third, please give your commits meaningful titles. "Update taskFlowCharmHadrons.cxx" does not tell me anything about what you changed.

@Tao-Fang
Copy link
Contributor Author

Tao-Fang commented Oct 14, 2025

Hi @Tao-Fang , thanks! Can you be more specific about how you did the local test, please?
I have used these commands, previous oversight was entering PWGHF/TableProducer instead of PWGHF.
"cd /home/linux/alice/sw/BUILD/O2Physics-latest/O2Physics/
alienv enter O2Physics/latest ninja/latest
ninja PWGHF/install"

Hi @Tao-Fang , first of all, these are wrong steps to recompile O2Physics. Where did you see them? Please follow the latest official instructions. Second, this is just compilation. What about the rest of testing (checking for compilation warnings, running, validating the output)? Third, please give your commits meaningful titles. "Update taskFlowCharmHadrons.cxx" does not tell me anything about what you changed.

Thank you for your comment. 1, Indeed it is not official one, I will follow the official documentation later. 2,There was not compilation warnings and running output is ok for my side

@vkucera
Copy link
Collaborator

vkucera commented Oct 14, 2025

Hi @Tao-Fang , thanks! Can you be more specific about how you did the local test, please?
I have used these commands, previous oversight was entering PWGHF/TableProducer instead of PWGHF.
"cd /home/linux/alice/sw/BUILD/O2Physics-latest/O2Physics/
alienv enter O2Physics/latest ninja/latest
ninja PWGHF/install"

Hi @Tao-Fang , first of all, these are wrong steps to recompile O2Physics. Where did you see them? Please follow the latest official instructions. Second, this is just compilation. What about the rest of testing (checking for compilation warnings, running, validating the output)? Third, please give your commits meaningful titles. "Update taskFlowCharmHadrons.cxx" does not tell me anything about what you changed.

Thank you for your comment. 1, Indeed it is not official one, I will follow the official documentation later. 2,There was not compilation warnings and running output is ok for my side

Thanks for checking.

@vkucera vkucera changed the title [PWGHF] Add ML to XicotoXiPi DCA Filter analysis [PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis Oct 14, 2025
@vkucera
Copy link
Collaborator

vkucera commented Oct 20, 2025

FYI: @jinhyun

@vkucera
Copy link
Collaborator

vkucera commented Oct 20, 2025

@Tao-Fang I don't have further comments.

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) October 21, 2025 13:42
@zhangbiao-phy zhangbiao-phy merged commit 7170abe into AliceO2Group:master Oct 21, 2025
19 of 20 checks passed
mapalhares pushed a commit to mapalhares/O2Physics that referenced this pull request Oct 23, 2025
@Tao-Fang @alibuild @mapalhares
[PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis (AliceO2Group#12758)
3922157 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@Tao-Fang @alibuild @ThePhDane
[PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis (AliceO2Group#12758)
15ecee5 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@Tao-Fang @alibuild
[PWGHF] Add ML to Xic0ToXiPi DCA Filter analysis (AliceO2Group#12758)
f200b46 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa fgrosa left review comments

@vkucera vkucera vkucera left review comments

@zhangbiao-phy zhangbiao-phy zhangbiao-phy approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tao-Fang @alibuild @fgrosa @vkucera @zhangbiao-phy