-
Notifications
You must be signed in to change notification settings - Fork 613
PWGHF: Separate prompt/nonprompt D+ and add different efficiency steps #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d8599cd
Separate prompt/nonprompt D+ and add different efficiency steps
fgrosa 93f2be6
Fix format
fgrosa 8c2146a
Implement Fabio's suggestions
fgrosa e02cacc
Fix format
fgrosa 0798960
Change default for selection in data process
fgrosa b511de3
Add histogram for efficiency at skim level
fgrosa bdb8dc5
Define enum with selection step
fgrosa 81e908c
Fix format
fgrosa 953b205
Fix format
fgrosa f835013
Substitute numbers with enum elements
fgrosa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that this line prevents calculation of efficiency without applying selector decision as it used to be before when
>= d_selectionFlagDPluswas used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it does not allow for the selection of all the 3-prong candidates, however what is the interest in selecting all the candidates that are not reconstructed as D+ in the HFTrackIndexSkimsCreator? Filtering the candidates that have at least
BIT(0)instead should improve a bit the execution time