Skip to content

[PWGLF] Fix autodetection of old format in strangeness tof pid #13236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romainschotter merged 3 commits into from
Oct 4, 2025
Merged

[PWGLF] Fix autodetection of old format in strangeness tof pid #13236

romainschotter merged 3 commits into from
Oct 4, 2025

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Oct 4, 2025

@github-actions github-actions bot added the pwglf label Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025 •
edited
Loading

O2 linter results: ❌ 44 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Oct 4, 2025
Merged
@ddobrigk ddobrigk marked this pull request as ready for review October 4, 2025 18:21
romainschotter
romainschotter previously approved these changes Oct 4, 2025
View reviewed changes
@romainschotter romainschotter enabled auto-merge (squash) October 4, 2025 18:28
@alibuild
Copy link
Collaborator

alibuild commented Oct 4, 2025

Error while checking build/O2Physics/o2 for 4d9dc9c at 2025-10-04 22:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1371:5: error: expected unqualified-id before 'if'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1376:5: error: expected unqualified-id before 'if'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1378:7: error: expected unqualified-id before 'else'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1384:33: error: 'dauTrackTable' has not been declared
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1384:46: error: expected ',' or '...' before '.' token
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1386:5: error: expected unqualified-id before 'if'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1391:7: error: expected unqualified-id before 'else'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1396:5: error: expected unqualified-id before 'if'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1457:5: error: expected unqualified-id before 'if'
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1524:4: error: expected ';' after struct definition
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1368:22: error: 'firstTOFPID' was not declared in this scope
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1361:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1361:134: error: unused parameter 'V0s' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1361:163: error: unused parameter 'cascades' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1361:190: error: unused parameter 'dauTrackTable' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13236-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:1528:1: error: expected declaration before '}' token
ninja: build stopped: subcommand failed.

Full log here.

@romainschotter romainschotter merged commit 4c1f9b2 into AliceO2Group:master Oct 4, 2025
11 of 12 checks passed
@ddobrigk ddobrigk deleted the dev31 branch October 5, 2025 14:12
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@ddobrigk @alibuild @jinhyunni
[PWGLF] Fix autodetection of old format in strangeness tof pid (Alice…
0265f6c 
…O2Group#13236)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
@ddobrigk @alibuild
[PWGLF] Fix autodetection of old format in strangeness tof pid (Alice…
95f43d1 
…O2Group#13236)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@ddobrigk @alibuild @ThePhDane
[PWGLF] Fix autodetection of old format in strangeness tof pid (Alice…
bd24702 
…O2Group#13236)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@ddobrigk @alibuild @jloemker
[PWGLF] Fix autodetection of old format in strangeness tof pid (Alice…
5783e05 
…O2Group#13236)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@ddobrigk @alibuild
[PWGLF] Fix autodetection of old format in strangeness tof pid (Alice…
dbcf8d0 
…O2Group#13236)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddobrigk @alibuild @romainschotter