[PWGEM,PWGHF,Trigger] Fix O2linter warnings #13264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhemmer-cern
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
dsekihat,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
lietava,
m-c-danisch,
mfaggin,
mikesas,
mmazzilli,
mpuccio,
novitzky,
rbailhac,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 637 errors, |
mhemmer-cern
force-pushed
the
em-cleanup
branch
from
abe1a73 to
4a0095b
Compare
Collaborator
Author
vkucera
reviewed
Oct 7, 2025
Collaborator
|
Thanks @mhemmer-cern for the great work! Very much appreciated. Please see my comments. (I might add more.) |
Contributor
|
Looks good from the heavy neutral meson trigger side (only addition of compiler flags and reordering of includes). Thank you @mhemmer-cern! |
mhemmer-cern
force-pushed
the
em-cleanup
branch
from
4a0095b to
fc13e9d
Compare
vkucera
reviewed
Oct 7, 2025
vkucera
reviewed
Oct 7, 2025
vkucera
reviewed
Oct 7, 2025
mhemmer-cern
force-pushed
the
em-cleanup
branch
2 times, most recently
from
88bad87 to
f27e6a3
Compare
vkucera
reviewed
Oct 7, 2025
Comment on lines
+28
to
+30
| // Dilepton headers | ||
| #include "PWGEM/Dilepton/Utils/EMTrack.h" | ||
| #include "PWGEM/Dilepton/Utils/EventMixingHandler.h" |
Collaborator
There was a problem hiding this comment.
Suggestion for codeowners of PWGEM/Dilepton and PWGEM/PhotonMeson. If there is common code used across PAGs, it makes more sense to have it in the common PWG directories.
mhemmer-cern
force-pushed
the
em-cleanup
branch
from
f27e6a3 to
dd9fc6c
Compare
vkucera
reviewed
Oct 7, 2025
vkucera
reviewed
Oct 7, 2025
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here. 1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example) 2. Cleaning up includes in most touched files here after the removal of `using` 3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons. 4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it. - Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern
force-pushed
the
em-cleanup
branch
from
dd9fc6c to
a674e4f
Compare
vkucera
approved these changes
Oct 7, 2025
Collaborator
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
Thanks @mhemmer-cern again for addressing all my comments. Good from my side.
Collaborator
Author
Dear @mpuccio could you approve this from the Trigger side please? |
mpuccio
approved these changes
Oct 7, 2025
alibuild
approved these changes
Oct 7, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWGHF:
PhysicsConstants.hwhich clashed with some local enum definitions here.PWGEM:
usingin some header files and necessary changes because of this removal (EventFiltering for example)usingTrigger:
[[maybe_unused]]to some local variables that are used as inital parameters for configurable to silence compiler warnings/clangd. Add comment for explanation of this change as well.